Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux AppData description #2732

Merged
merged 1 commit into from Aug 5, 2023
Merged

Update Linux AppData description #2732

merged 1 commit into from Aug 5, 2023

Conversation

rderooy
Copy link
Collaborator

@rderooy rderooy commented Aug 5, 2023

Simplify description. Remove feature list as discussed, to prevent having to update the description for each release.

Fixes #2717

@rderooy rderooy requested a review from johnnovak August 5, 2023 09:53
@rderooy rderooy self-assigned this Aug 5, 2023
@rderooy
Copy link
Collaborator Author

rderooy commented Aug 5, 2023

Your not supposed to put links in the description. If you look for instance at the flatpak page, you will see there are buttons for homepage and bugtracker, which are defined in the XML.

Here are the supported URL's:
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#spec-component-filespec

The definition allows for the following URL types:

  • homepage
  • bugtracker
  • faq
  • help
  • donation
  • translate
  • contact
  • vcs-browser
  • contribute

But not every renderer may necessarily show all URLs.

@kcgen kcgen added the packaging Issues about packaging DOSBox Staging for various OSes label Aug 5, 2023
@kcgen kcgen merged commit 2ea8b48 into main Aug 5, 2023
50 checks passed
@kcgen kcgen deleted the rdr/appstream branch August 5, 2023 16:10
@johnnovak
Copy link
Member

Your not supposed to put links in the description. If you look for instance at the flatpak page, you will see there are buttons for homepage and bugtracker, which are defined in the XML.

Makes sense, and that's what I suspected @rderooy. I guess the URL must be defined in another file then because I can't find it in this one.

@rderooy
Copy link
Collaborator Author

rderooy commented Aug 5, 2023

Makes sense, and that's what I suspected @rderooy. I guess the URL must be defined in another file then because I can't find it in this one.

I'm not following. Towards the end of the file there are two URLs.

  <url type="homepage">https://dosbox-staging.github.io/</url>
  <url type="bugtracker">https://github.com/dosbox-staging/dosbox-staging/issues</url>

@johnnovak
Copy link
Member

Makes sense, and that's what I suspected @rderooy. I guess the URL must be defined in another file then because I can't find it in this one.

I'm not following. Towards the end of the file there are two URLs.

  <url type="homepage">https://dosbox-staging.github.io/</url>
  <url type="bugtracker">https://github.com/dosbox-staging/dosbox-staging/issues</url>

Oh right, I did not press the little arrow to see the rest of the file 😄 Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Issues about packaging DOSBox Staging for various OSes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Linux Feature description
3 participants