Cleanup among PCI/Memory constants #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeralChild64
added
the
cleanup
FeralChild64
force-pushed
the
fc/pci-memory-cleanup-1
branch
from
c287633
to
da7a8e1
Compare
johnnovak
reviewed
Aug 5, 2023
johnnovak
reviewed
Aug 5, 2023
johnnovak
reviewed
Aug 5, 2023
johnnovak
approved these changes
Aug 5, 2023
FeralChild64
force-pushed
the
fc/pci-memory-cleanup-1
branch
from
da7a8e1
to
c81245f
Compare
FeralChild64
added
the
refactoring
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When experimenting with PCI code I have found that start/end addresses of various memory areas are scattered across various files. This is dangerous - one can easily put a new PCI card in an already occupied space. It is better to have all these constants in one place.
Additionally, I have removed one empty header file.