Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix altered shader pragmas not taking an effect when reloading the shader #2736

Merged
merged 1 commit into from Aug 6, 2023
Merged

Fix altered shader pragmas not taking an effect when reloading the shader #2736

merged 1 commit into from Aug 6, 2023

Conversation

johnnovak
Copy link
Member

Not an issue during normal operation, only when tweaking shaders and reloading them, but then it's confusing and annoying.

@johnnovak johnnovak marked this pull request as ready for review August 6, 2023 12:18
@johnnovak johnnovak added bug Something isn't working video Graphics and video related issues labels Aug 6, 2023
@johnnovak johnnovak self-assigned this Aug 6, 2023
@johnnovak johnnovak merged commit 154b2a2 into main Aug 6, 2023
50 checks passed
@johnnovak johnnovak deleted the jn/fix-changing-shader-pragmas-on-reload branch August 6, 2023 22:46
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
@johnnovak johnnovak added the shaders Issues related to shaders label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeralChild64 FeralChild64 FeralChild64 approved these changes

Assignees

@johnnovak johnnovak

Labels
bug Something isn't working shaders Issues related to shaders video Graphics and video related issues
Projects
0.81 Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnnovak @FeralChild64