Mixer refactoring & cleanup

[johnnovak]

Just some cleanup in preparation for the two mixer tickets in my queue. No functional changes.

[kcgen]

We're pretty close to being able to add the narrowing checks to mixer.cpp:

#include "checks.h"
CHECK_NARROWING();

I think there's 6 remaining issues - could go for that too, if you like :-)

[johnnovak]

We're pretty close to being able to add the narrowing checks to mixer.cpp:

#include "checks.h"
CHECK_NARROWING();

I think there's 6 remaining issues - could go for that too, if you like :-)

Oh yeah, I'll just do it, thanks for reminding.

[johnnovak]

@kcgen Is there anything we can do when we get the "out of space" errors on CI?

Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
Download action repository 'actions/cache@v3.3.1' (SHA:88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8)
Error: No space left on device

https://github.com/dosbox-staging/dosbox-staging/actions/runs/5982536984/job/16231715952?pr=2787

Edit: Oh, looks like there is—ask you to make more space 😎

Current runner version: '2.308.0'
Runner name: 'kcgens-macos-m1-mini-1'

[johnnovak]

All done @kcgen, I've done a few more improvements. I'll wait until you fix your Mac Mini situation 😄

[kcgen]

Nice cleanup @johnnovak ! Nothing more from me (and CI is happy now :-)

[johnnovak]

Nice cleanup @johnnovak ! Nothing more from me (and CI is happy now :-)

Thanks man, merging 😎