Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SDLOSXCAGuard files to UTF-8 #2982

Merged
merged 1 commit into from Oct 10, 2023
Merged

Conversation

MaddTheSane
Copy link
Contributor

Description

This simply coverts the files SDLOSXCAGuard.c and SDLOSXCAGuard.h from Mac OS Roman to UTF-8, quieting an issue with Clang about "invalid UTF-8 in comment."

Manual testing

I don't perceive this having any impact to any actual code, but might make the Apple license in those files more readable.

Checklist

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

@kcgen
Copy link
Member

kcgen commented Oct 10, 2023

Thanks for the fix, @MaddTheSane -- indeed, those copyright and apostrophe characters previously were shown as broken in my text editors.

@kcgen kcgen merged commit fd7b9c2 into dosbox-staging:main Oct 10, 2023
@johnnovak johnnovak added the cleanup Non-functional changes that simplify, improve maintainability, or squash warnings label Nov 13, 2023
@MaddTheSane MaddTheSane deleted the utfConv branch March 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional changes that simplify, improve maintainability, or squash warnings
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants