Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVS Studio warning fixes #3070

Merged
merged 6 commits into from Oct 29, 2023
Merged

PVS Studio warning fixes #3070

merged 6 commits into from Oct 29, 2023

Conversation

FeralChild64
Copy link
Collaborator

Description

Fixed few warnings.

Checklist

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

@FeralChild64 FeralChild64 added the cleanup Non-functional changes that simplify, improve maintainability, or squash warnings label Oct 29, 2023
@FeralChild64 FeralChild64 self-assigned this Oct 29, 2023
Copy link
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit by comment, all looks great.
First time below 160 on the PVS front!

2023-10-29_08-33

Created with:

git log --pretty=format:"%h %ad" --date=short --follow -- "$1" | \
while read commit_hash commit_date; do
  git show "$commit_hash" -- "$1" | grep "$2" | sed "s/^/$commit_date - /"
done
./line_history.sh .github/workflows/pvs-studio.yml "^+.*MAX_BUGS:" \
 | tac \
 | sed 's/ - +          MAX_BUGS: /,/g' \
 > pvs_bugs.csv

And to see when we updated PVS Studio:

.github/workflows/pvs-studio.yml "^+.*debfile:" | tac

src/hardware/ipx.cpp Show resolved Hide resolved
@kcgen kcgen merged commit 19d83a6 into main Oct 29, 2023
50 checks passed
@FeralChild64
Copy link
Collaborator Author

At some point we’ll need to dig into the CPU emulation code. There is about 60 warning originating there.

@kcgen
Copy link
Member

kcgen commented Oct 29, 2023

At some point we’ll need to dig into the CPU emulation code:

@FeralChild64, at the code table:

2023-10-29_10-20

@kcgen
Copy link
Member

kcgen commented Oct 29, 2023

(I love that old pic of a kid digging into pancakes :-)

@FeralChild64 FeralChild64 deleted the fc/pvs-studio-fixes-1 branch October 29, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional changes that simplify, improve maintainability, or squash warnings
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants