New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PVS Studio warning fixes #3070
PVS Studio warning fixes #3070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed commit by comment, all looks great.
First time below 160 on the PVS front!
Created with:
git log --pretty=format:"%h %ad" --date=short --follow -- "$1" | \
while read commit_hash commit_date; do
git show "$commit_hash" -- "$1" | grep "$2" | sed "s/^/$commit_date - /"
done
./line_history.sh .github/workflows/pvs-studio.yml "^+.*MAX_BUGS:" \
| tac \
| sed 's/ - + MAX_BUGS: /,/g' \
> pvs_bugs.csv
And to see when we updated PVS Studio:
.github/workflows/pvs-studio.yml "^+.*debfile:" | tac
At some point we’ll need to dig into the CPU emulation code. There is about 60 warning originating there. |
@FeralChild64, at the code table: |
(I love that old pic of a kid digging into pancakes :-) |
Description
Fixed few warnings.
Checklist
I have: