Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise warnings messages #3143

Merged
merged 1 commit into from Nov 21, 2023
Merged

Normalise warnings messages #3143

merged 1 commit into from Nov 21, 2023

Conversation

johnnovak
Copy link
Member

@johnnovak johnnovak commented Nov 20, 2023

Description

I've just done a warning message normalisations sweep for consistency. I like consistency, as you can tell 馃槑

I left the viewport_resolution related warnings intentionally alone as I'm addressing those in my upcoming PR.

Manual testing

DOSBox still compiles & starts up 馃槃 (no functional changes)

Checklist

Please tick the items as you have addressed them. Don't remove items; leave the ones that are not applicable unchecked.

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

@johnnovak johnnovak self-assigned this Nov 20, 2023
@johnnovak johnnovak added the enhancement New feature or enhancement of existing features label Nov 20, 2023
@johnnovak johnnovak marked this pull request as ready for review November 20, 2023 08:17
@johnnovak johnnovak mentioned this pull request Nov 20, 2023
10 tasks
src/capture/image/image_capturer.cpp Outdated Show resolved Hide resolved
src/capture/image/image_capturer.cpp Outdated Show resolved Hide resolved
src/capture/image/image_capturer.cpp Outdated Show resolved Hide resolved
src/gui/sdlmain.cpp Show resolved Hide resolved
src/hardware/joystick.cpp Show resolved Hide resolved
Copy link
Collaborator

@weirddan455 weirddan455 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor wording suggestion

src/gui/sdlmain.cpp Outdated Show resolved Hide resolved
@johnnovak johnnovak merged commit 59b5153 into main Nov 21, 2023
50 checks passed
@kcgen kcgen deleted the jn/normalise-warnings branch December 4, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants