Cleanup a handful of unchecked return-code issues flagged by Coverity #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcgen
added
the
cleanup
kcgen
force-pushed
the
kc/coverity-return-codes-1
branch
from
db8bd22
to
cf51aab
Compare
johnnovak
reviewed
Dec 6, 2023
johnnovak
reviewed
Dec 6, 2023
johnnovak
reviewed
Dec 6, 2023
johnnovak
reviewed
Dec 6, 2023
weirddan455
approved these changes
Dec 6, 2023
FeralChild64
reviewed
Dec 6, 2023
kcgen
force-pushed
the
kc/coverity-return-codes-1
branch
6 times, most recently
from
8263c65
to
02c2818
Compare
After calling cmds.erase(...), 'it' becomes invalid because we've erased the item to which it points. Coverity doesn't like that the (now invalid) iterator 'it' is used again on the next pass through the loop, when we pass it to the FindEntry function. Although we know the FindEntry function immediately overwrites 'it', we should at least not be passing around invalid iterators, regardless.
IF the image and boot files are truncated or corrupt, these fseek files will fail however without checking them, we will read or write subsequent garbage. This commit checks the fseek result code and will log and close the file on failure.
kcgen
force-pushed
the
kc/coverity-return-codes-1
branch
from
02c2818
to
e7cf7a9
Compare
|
(Might as well get this merged) |
|
Confirmed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a handful of unchecked return-code issues flagged by the updated Coverity scanner.
Related issues
Manual testing
Tested shell command line handling and booting floppy and HDD images.
Also tested with UBSAN and ASAN builds.
Checklist
I have: