Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CD-ROM Speed (may help with games that request it) #3776

Closed
2 tasks done
xga-cga opened this issue Jun 18, 2024 · 10 comments
Closed
2 tasks done

Set CD-ROM Speed (may help with games that request it) #3776

xga-cga opened this issue Jun 18, 2024 · 10 comments
Labels
enhancement New feature or enhancement of existing features

Comments

@xga-cga
Copy link

xga-cga commented Jun 18, 2024

Are you using the latest Dosbox-Staging Version?

  • I have checked releases and am using the latest release.

Different version than latest?

No response

What Operating System are you using?

None

If Other OS, please describe

No response

Is your feature request related to a problem? Please describe.

feature added in DOSBOX-X
joncampbell123/dosbox-x#2835

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Add any other context or screenshots about the feature request here.

No response

Code of Conduct & Contributing Guidelines

  • Yes, I agree.
@xga-cga xga-cga added the enhancement New feature or enhancement of existing features label Jun 18, 2024
@weirddan455
Copy link
Collaborator

It would be nice to confirm what games (f any) actually have problems on Staging due to this. I'm aware that some games will throw a warning during install when they try to detect the CDROM speed (ex. Wing Commander 3) but whenever I've encountered this, the game installs and plays fine regardless.

There's a lot of features DOSBox-X has that we have no plans to implement. We have no hard drive speed limiter either that I'm aware of.

At least from my perspective, I would need to see a concrete problem (more than just an installer warning that can be bypassed) before I spend time working on it. I suppose this ticket can stay up as a feature request if someone else wants to work on it but you still might want to sell it more with a real problem that needs to be solved.

@Grounded0
Copy link
Collaborator

Grounded0 commented Jun 18, 2024

Yeah i want a list of apps and games impacted directly in a showstopper manner and not as an annoyance like CD-ROM speed check throwing a warning on install.

@johnnovak
Copy link
Member

johnnovak commented Jun 18, 2024

@xga-cga Please build up a case for this. We don't just implement features and port over stuff if it's not proven to solve a concrete problem.

We need a list of games that require this DOSBox-X feature and do not work in Staging without it.

For each game, please specify the value of the DOSBox-X CD-ROM speed setting you've tested with.

@Burrito78
Copy link
Collaborator

It would be no problem for us to just soak up a lot of "nice" DOSBox-X features but:

It means it takes time/energy to:

  1. Integrate it into Staging with our coding standards and practices.
  2. Do bug and regression testing after integration.
  3. Risk new bugs as a result of integration that aren't found at first.
  4. Some Staging contributor has to "own" the feature in the future to keep it working and update the code when necessary, when he leaves, the feature is in there to rot when nobody picks it up to care for it - which most often doesn't happen, if its nothing fundamentally important.

For these reasons, changes to the codebase must have a proper reason, and that reason has to be a games behaving badly or worse than other DOSBox forks.

@johnnovak
Copy link
Member

johnnovak commented Jun 19, 2024

Exactly @Burrito78. We won't just start indiscriminately shovelling over features from other projects, lol 😄 That's not how you do software 😆

@MasterO2
Copy link
Contributor

Exactly @Burrito78. We won't just start indiscriminately shoveling over features from other projects, lol 😄 That's not how you do software 😆

Judging by xga-cga's lack of a response so far, there must not be very many games at all where setting a specific CD-ROM speed is needed to run them properly.

@Grounded0
Copy link
Collaborator

They mostly had minimum speed requirements that you had enough data coming per second to display a Smacker video and such:

https://en.wikipedia.org/wiki/Smacker_video

@johnnovak
Copy link
Member

They mostly had minimum speed requirements that you had enough data coming per second to display a Smacker video and such:

https://en.wikipedia.org/wiki/Smacker_video

And some setup utils ask you whether you have a double, triple, etc. speed drive.

@weirddan455
Copy link
Collaborator

Closing this due to no response. I don't see anyone jumping to implement this without a concrete use-case.

@weirddan455 weirddan455 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 7, 2024
@johnnovak
Copy link
Member

Closing this due to no response. I don't see anyone jumping to implement this without a concrete use-case.

Good call. We want to keep the issue tracker clean and close low-value tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing features
Projects
None yet
Development

No branches or pull requests

6 participants