Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation work (BR, DE, ES, FR, IT, NL, PL, RU, others…) #884

Closed
dreamer opened this issue Feb 12, 2021 · 294 comments
Closed

Translation work (BR, DE, ES, FR, IT, NL, PL, RU, others…) #884

dreamer opened this issue Feb 12, 2021 · 294 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or enhancement of existing features good first issue Good for newcomers help wanted Community help wanted translation Issues related to translations

Comments

@dreamer
Copy link
Member

dreamer commented Feb 12, 2021


NOTE: Since the issue was created, a little has changed in the translation workflow; hopefully it is easier now. See the current guide here:
https://github.com/dosbox-staging/dosbox-staging/blob/main/contrib/resources/translations/README.md

Original issue content below. Yours truly - @FeralChild64


This issue is a continuation of #776.

We are happy for new translators to join-in - leave a comment!

Right now, DOSBox Staging has its own, legacy, quirky translation system based on "language files". To test it, you need to obtain a language file from somewhere, copy it to DOSBox Staging config directory and set e.g.:

[dosbox]
language = fr_FR.lng

[autoexec]
keyb fr

There's also keyboardlayout in [dos] section, but I don't know how it works.

Problems with this system

  1. The language files need to use old DOS encoding appropriate for given language and as of 2021 it's very annoying to reconfigure text editors to not use Unicode.
  2. Translators have no idea when the programmers changed some translation string, so language files get outdated fast.

Solution to problem (1)

In directory contrib/translations/utf-8/ there are translation files encoded in UTF-8 - these are the source files for translators to work with (if you want to start a new translation - ask and I'll prepare a new file):

contrib/translations/utf-8/
├── en
│   └── en-0.77.0-alpha.txt
├── fr
│   └── fr-0.77.0-alpha.txt
└── pl
    └── pl-0.77.0-alpha.txt

After changing one of those files, run script encode.sh, and copy/link the file you want to use:

$ ./contrib/translations/encode.sh 
In directory ./contrib/translations:
Encoding utf-8/en/en-0.77.0-alpha.txt with CP437 to en/en_US.lng
Encoding utf-8/fr/fr-0.77.0-alpha.txt with CP858 to fr/fr_FR.lng
Encoding utf-8/pl/pl-0.77.0-alpha.txt with CP852 to pl/pl_PL.lng
Encoding utf-8/pl/pl-0.77.0-alpha.txt with CP437 to pl/pl_PL.CP437.lng

$ cp contrib/translations/pl/pl_PL.lng ~/.config/dosbox/

After you translated few strings - submit new utf-8 .txt language file in here (either as PR or make a comment in this thread and upload new .txt file). Translations don't need to be 100% complete - I can handle partial updates as well :)

Solution to problem (2)

Whenever programmers change strings in the code, I will update utf-8/en/en-0.77.0-alpha.txt file and leave a comment in this topic linking to the change, so all translators will know if something needs to be added/removed/edited.

There's no rush nor deadlines - submit updates to translations when you have time :)

~1 month before 0.77.0 final release I will announce a "string freeze" to give translators some time to push files to 100% :)

Translated files for older versions of DOSBox

I gathered all old translations I could find in contrib/old-translations/ - some translation work from those old files can be salvaged, but many of files in there are probably outdated.

Wait, this is all very confusing

Yup - that's why this is only temporary.

Once #854 will be finished, we'll start transition to new, normal, translation system: gettext - it will give translators better tools to see how strings changed, and will make the encoding part completely automatic :)

If gettext-based translations will be ready to go for 0.77.0 then I will convert all up-to-date, new language files to the new format and from that point forward translators will be able to use much better tools, e.g. poedit and we'll be able to coordinate with established translation groups.

If gettext will get postponed to 0.78.0, then I'll bundle all finished language files with the 0.77.0 release packages.

@dreamer dreamer added the enhancement New feature or enhancement of existing features label Feb 12, 2021
@dreamer
Copy link
Member Author

dreamer commented Feb 12, 2021

@Draky50110 let's continue work on translations in this thread - this way I will be able to communicate changes to all translators at once :)

@IlyaIndigo I'll prepare a new utf-8 file for Russian translation momentarily.

@dreamer dreamer added good first issue Good for newcomers documentation Improvements or additions to documentation labels Feb 12, 2021
@dreamer dreamer pinned this issue Feb 12, 2021
@dreamer dreamer changed the title Translation work (FR, RU, PL) Translation work (FR, RU, PL, others…) Feb 12, 2021
@dreamer dreamer added the help wanted Community help wanted label Feb 12, 2021
@dreamer dreamer added this to To do in 0.77.0 release via automation Feb 12, 2021
@dreamer dreamer moved this from To do to In progress in 0.77.0 release Feb 12, 2021
@dreamer
Copy link
Member Author

dreamer commented Feb 12, 2021

@IlyaIndigo I prepared utf-8 file for translation, and copied first string from older translation file: ea56f89 :)

dreamer referenced this issue Feb 16, 2021
Use 'keyb ru' to see cyrillic :)
@IlyaIndigo
Copy link
Contributor

@dreamer Well, if you need my help with translation into Russian or Ukrainian, write to me, mentioning my nickname, I will answer here.

@dreamer
Copy link
Member Author

dreamer commented Feb 19, 2021

Small update: one of translation strings got removed - I already updated all translation files in 9d0f7c7.

@Draky50110 Update your translation file, please :)

@IlyaIndigo we don't have any other volunteers to work on Russian translation so yeah - work on this is appreciated - thank you! Let's start with ru_RU :)

@IlyaIndigo
Copy link
Contributor

@dreamer Okay. I won't have time this weekend, but I'll translate next week.

@IlyaIndigo
Copy link
Contributor

@dreamer In the file dosbox-staging/contrib/translations/en/ru_RU.lng all English text, which from ":SECTION_NAME" to ".", not including SECTION_NAME should be replaced by Russian?
Do I understand it right?

@Draky50110
Copy link
Contributor

Draky50110 commented Feb 20, 2021

All done : finished VER command and removed the synth help lines ;)
Here is up to date FR language file.
fr-0.77.0-alpha.txt

@kcgen
Copy link
Member

kcgen commented Feb 20, 2021

CONFIG_OPLRATE can also be removed.
Thank you @Draky50110!

@dreamer
Copy link
Member Author

dreamer commented Feb 20, 2021

@IlyaIndigo That's correct :)

@kcgen nope, CONFIG_OPLRATE is an error message explaining deprection - I brought it back in french translation file (it never left english one) - in English it says:

oplrate is deprecated. The OPL waveform is now sampled at the mixer's playback rate to avoid resampling.

It does not appear by default in .conf file, but it appears e.g. in Z:\> config -? oplrate (and maybe in other places as well, I'm not sure).

Just a reminder that dealing with translation strings and user interfaces can be tricky ;)

I prepared a script to automatically drop english translation: ./contrib/translations/update-en.sh - you can use it to make sure what exactly changed.

@Draky50110 Thank you for an update :) Committed as 0473a58

Although I have a small concern: in mount /? and imgmount /? sections are named: Usage :, Avec :, Notes :, Exemples : - however in ver /? they are translated as: Utilisation :, Où :, Notes :, Exemples :.

Looks great:
Screenshot from 2021-02-20 21-12-57

@kcgen
Copy link
Member

kcgen commented Feb 20, 2021

CONFIG_OPLRATE is an error message explaining deprecation

@dreamer , @Draky50110 -- D'oh; my apologies! Thank you for quickly catching this!

Just a reminder that dealing with translation strings and user interfaces can be tricky ;)

Consider me reminded 💯

@Draky50110
Copy link
Contributor

Ok, I reworked on translation :p
So :

  • CONFIG_OPLRATE restablished ;)
  • changed "Où :" to "Avec :" to have same word everywhere

Last from this day :
fr-0.77.0-alpha.txt

@dreamer maybe you can push it now ;)
By the way, as I use your iconv line (from script) I tested the VER help to see if it fitted the space and corrected it before uploading it ;)

@dreamer
Copy link
Member Author

dreamer commented Feb 21, 2021

@Draky50110 Thanks! c4b660e :) Should I change "Usage" to "Utilisation" in other messages?

@Draky50110
Copy link
Contributor

So good question.
Just looked at french offical MSDOS 6.22 and help command returns another word :D
It uses "Syntaxe" (French for English word "Syntax") lol

Here is french text for "XCOPY" command :

Webp net-resizeimage

@IlyaIndigo
Copy link
Contributor

IlyaIndigo commented Feb 26, 2021

I'm sorry, I already understood the correct way, I just got confused by the complex sentence structure and didn't immediately understand what was meant, i.e. I translated incorrectly.
And it is so in almost all new staging sentences, a very bad and wrong structure of English, that sometimes you have to guess what the author meant and write it down in your own words.
So the translation is slower than I expected.

@kcgen
Copy link
Member

kcgen commented Feb 26, 2021

Fully agree @IlyaIndigo!

@IlyaIndigo
Copy link
Contributor

IlyaIndigo commented Feb 26, 2021

Current progress 408/1430 lines, finished :CONFIG_* options.
Just in case, I'm posting the intermediate result.
ru_RU.lng.txt

@kcgen
Copy link
Member

kcgen commented Feb 26, 2021

I just got confused by the complex sentence structure and didn't immediately understand what was meant

Thanks @IlyaIndigo; this PR attempts to improve that wording: https://github.com/dosbox-staging/dosbox-staging/pull/919/files

And it is so in almost all new staging sentences, a very bad and wrong structure of English, that sometimes you have to guess what the author meant and write it down in your own words.

Please flag any others!

@IlyaIndigo
Copy link
Contributor

Please flag any others!

There are a lot of them, I can not list them all, perhaps later I will bring them all.
Here is the shortest one I remember.

:CONFIG_PREBUFFER
How many milliseconds of data to keep on top of the blocksize.

There is such meaningless nonsense in this short sentence... ...milliseconds of data...
I translated it into Russian as:
How many milliseconds you need to hold the data on top of the block.
But I'm not sure about the ending, maybe a buffer or a stack instead of a block?
And is the data really held exactly at the top of the block, not just in the block?

@IlyaIndigo
Copy link
Contributor

I also made non-translation changes in some places.

:CONFIG_MIDICONFIG
.....................................
- When using ALSA, use Linux command 'aconnect -l' to list open
  MIDI ports, and select one (for example 'midiconfig=14:0'
  for sequencer client 14, port 0).
- При использовании ALSA, используйте Linux команду 'aplaymidi -l' для показа
  списка доступных MIDI-портов, и выберите один (например, 'midiconfig=128:0').
  для клиента секвенсора 128, порт 0).
  
  :CONFIG_SOUNDFONT
  .....................................
  For example: 'soundfont.sf2 50' will attenuate it by 50 percent.
  Например: 'FluidR3_GM.sf2 50' ослабит её на 50 процентов.
  
  :AUTOEXEC_CONFIGFILE_HELP
Lines in this section will be run at startup.
You can put your MOUNT lines here.
Строки в этом разделе будут выполняться при запуске.
Вы можете размещать свои строки 'mount' здесь.
mount C .
C:

:CONFIG_MIDIDEVICE
I formatted the indents in the pseudo-table, which were previously encountered in similar designs.

In some places it said dosbox instead of DOSBox.
In some places, sentences start with a small letter, even where there is no colon before it.
In all places where this was not the case, the parameters and values mentioned in the sentence are enclosed in apostrophes.

@Kappa971
Copy link
Contributor

Kappa971 commented Oct 4, 2023

Maybe take a look at how it's parsed in C and C-like highlighters.

They highlight all the numbers. I can turn on number highlighting for my DOSBox .lng user-defined language, but this will highlight all the numbers in the text, not just the C ones that start with %. If there's a way to do it, I haven't found it.

@Kappa971
Copy link
Contributor

Kappa971 commented Oct 5, 2023

I found a workaround (not perfect), this is the new file: DOSBox LNG2.zip
As mentioned, if someone can find a better solution (he can easily change everything), I won't be offended.
(or maybe everyone here uses Linux and so no one cares 🤣).

@Kappa971
Copy link
Contributor

I think for completeness, the DOSBox Staging help screen should also be translated:

Usage: dosbox [OPTION]... [FILE]

List of available options:

  --conf <config_file>     Start with the options specified in <config_file>.
                           Multiple configuration files can be specified.
                           Example: --conf conf1.conf --conf conf2.conf

  --printconf              Print the location of the primary configuration file.

  --editconf               Open the primary configuration file in a text editor.

  --eraseconf              Delete the primary configuration file.

  --noprimaryconf          Don't load or create the the primary configuration file.

  --nolocalconf            Don't load the local "dosbox.conf" configuration file
                           if present in the current working directory.

  --set <setting>=<value>  Set a configuration setting. Multiple configuration
                           settings can be specified. Example:
                           --set mididevice=fluidsynth --set soundfont=mysoundfont.sf2

  --working-dir <path>     Set working directory to <path>. DOSBox will act as if
                           started from this directory.

  --list-glshaders         List all available OpenGL shaders and their paths.
                           Results are useable in the "glshader = " config setting.

  --fullscreen             Start in fullscreen mode.

  --lang <lang_file>       Start with the language specified in <lang_file>.

  --machine <type>         Emulate a specific type of machine. The machine type has
                           influence on both the emulated video and sound cards.
                           Valid choices are: hercules, cga, cga_mono, tandy,
                           pcjr, ega, svga_s3 (default), svga_et3000, svga_et4000,
                           svga_paradise, vesa_nolfb, vesa_oldvbe.

  -c <command>             Run the specified DOS command before running FILE.
                           Multiple commands can be specified.

  --noautoexec             Don't execute DOS commands from any [autoexec] sections.

  --exit                   Exit after the DOS program specified by FILE has ended.
                           If no FILE has been specified, execute [autoexec] and
                           terminate.

  --startmapper            Run the mapper GUI.

  --erasemapper            Delete the default mapper file.

  --securemode             Enable secure mode. The [config] and [autoexec] sections
                           of the loaded configurations will be ignored, and
                           commands such as MOUNT and IMGMOUNT are disabled.

  --socket <num>           Run nullmodem on the specified socket number.

  -h, --help               Print this help message and exit.

  -v, --version            Print version information and exit.

@Kappa971
Copy link
Contributor

Kappa971 commented Oct 26, 2023

Sorry but what does this mean?

:CONFIG_CROSSFEED
  - The crossfeed strength of subsequently activated mixer channels will be
    set to the preset defaults.

:CONFIG_REVERB
  - Reverb levels of subsequently activated mixer channels will be set to the
    preset defaults.

:CONFIG_CHORUS
  - Chorus levels of subsequently activated mixer channels will be set to the
    preset defaults.

EDIT
What?? 😕

:SHELL_CMD_MIXER_HELP_LONG
  - The reverb and chorus commands also enable the default reverb and chorus
    presets, respectively, if those effects are not yet enabled.

And why reverb, chorus and crossfeed can be set both from the MIXER command and from dedicated settings in the configuration file?? It's all counterintuitive.

Anyway, I just need to understand what I'm writing.

@johnnovak
Copy link
Member

Sorry but what does this mean?

:CONFIG_CROSSFEED
  - The crossfeed strength of subsequently activated mixer channels will be
    set to the preset defaults.

:CONFIG_REVERB
  - Reverb levels of subsequently activated mixer channels will be set to the
    preset defaults.

:CONFIG_CHORUS
  - Chorus levels of subsequently activated mixer channels will be set to the
    preset defaults.

EDIT What?? 😕

:SHELL_CMD_MIXER_HELP_LONG
  - The reverb and chorus commands also enable the default reverb and chorus
    presets, respectively, if those effects are not yet enabled.

And why reverb, chorus and crossfeed can be set both from the MIXER command and from dedicated settings in the configuration file?? It's all counterintuitive.

Anyway, I just need to understand what I'm writing.

Read all relevant config descriptions of the features.

Read the MIXER's help text.

Read the release notes of the reverb and chorus features.

Play around with the features.

As a translator, it's your job to understand the functionality; you can't just blindly translate in many cases. All the info is there.

@Kappa971
Copy link
Contributor

Kappa971 commented Oct 26, 2023

As a translator, it's your job to understand the functionality; you can't just blindly translate in many cases. All the info is there.

I wasted an hour trying to understand the meaning of those sentences and I don't even know what tests to do, because I don't know what they mean. If the information was clearer, I wouldn't had any difficulties.
This answer is of no help to me, and if you don't want to help me understand, I will make a literal translation of what is written because I can't do anything else.

I think it would be helpful to rephrase the sentences in a less cryptic way, even for users, or maybe simplify the mechanism a bit because it seems very confusing to me.

@johnnovak
Copy link
Member

johnnovak commented Oct 26, 2023

Staring at the sentences for another hour certainly won't help 😄 I did help you, so I'm asking again:

Have you read all the materials I suggested to read @Kappa971? Including the release notes? Search for "reverb" on our website to find the relevant release notes. That's important as the features are described in detail there.

If you understand that, translating the configs should be no problem if your English is up to scratch 😄

We can't write novels in the config descriptions; those are more reminders than full explanations. Lenghty full explanations with examples will be in the user manual. For now, they live in the release notes.

Good luck 😄

@Kappa971
Copy link
Contributor

Kappa971 commented Oct 26, 2023

Staring at the sentences for another hour certainly won't help 😄 I did help you, so I'm asking again:

Have you read all the materials I suggested to read @Kappa971? Including the release notes? Search for "reverb" on our website to find the relevant release notes. That's important as the features are described in detail there.

If you understand that, translating the configs should be no problem if your English is up to scratch 😄

We can't write novels in the config descriptions; those are more reminders than full explanations. Lenghty full explanations with examples will be in the user manual. For now, they live in the release notes.

Good luck 😄

I'm not paid to do this job and I'm not a professional translator or a programmer, but I'm a volunteer and doing what you ask would require additional hours.
If I did as you say for every new option that I don't understand (luckily I understand 95% of the options, the others are technical options that I understood thanks to quick web searches), it would take me forever.

If you don't want or can't reply to me with short sentences explaining those 4 sentences (well actually the first 3 say the same thing for crossfeed, reverb and chorus, so 2 sentences) or maybe rewrite the sentences so they can be understood more easily, there's nothing else to say, so... thanks anyway, good night.

@johnnovak
Copy link
Member

johnnovak commented Oct 27, 2023

Same for me mate, I'm a volunteer too, remember? If you can't read the release notes where the feature is described clearly for regular users, I won't read it together with you...

Let me point out that if you spent the energy on reading the release notes instead of arguing with me, you'd know by now how the feature works... But you spent the time on pointless replies.

Have you read the release notes yet? Yes or no.

So that is a choice too, being agreeable and working together with the maintainers instead of annoying them and putting extra burden on them.

If you're unwilling to put in the effort required, maybe the job is not for you.

@kcgen
Copy link
Member

kcgen commented Oct 27, 2023

Potential simplification:

:CROSSFEED_SETTINGS
    Sets the default crossfeed strength for newly activated mixer channels.

:REVERB_SETTINGS
    Sets the default reverb level for newly activated mixer channels.

:CHORUS_SETTINGS
    Sets the default chorus level for newly activated mixer channels.

And why reverb, chorus and crossfeed can be set both from the MIXER command and from dedicated settings in the configuration file?? It's all counterintuitive.

The conf's [mixer] settings are applied to all audio channels.

Where as applying reverb, chorus, and crossfeed from the MIXER allows you to customize per-channel effect strengths (or disable them per-channel, if you like), just how each channel's relative volume can be adjusted with the MIXER.

@johnnovak
Copy link
Member

johnnovak commented Oct 27, 2023

Potential simplification:

:CROSSFEED_SETTINGS
    Sets the default crossfeed strength for newly activated mixer channels.

:REVERB_SETTINGS
    Sets the default reverb level for newly activated mixer channels.

:CHORUS_SETTINGS
    Sets the default chorus level for newly activated mixer channels.

And why reverb, chorus and crossfeed can be set both from the MIXER command and from dedicated settings in the configuration file?? It's all counterintuitive.

The conf's [mixer] settings are applied to all audio channels.

Where as applying reverb, chorus, and crossfeed from the MIXER allows you to customize per-channel effect strengths (or disable them per-channel, if you like), just how each channel's relative volume can be adjusted with the MIXER.

Let's step back a bit and look at the full picture—we went into detail territory here and off on tangents.

The main descriptions (first sentence) of these settings are fine and accurate, nothing to do there.

The extra notes section contains additional info; that's where @Kappa971's problems started. The "XXX of subsequently activated mixer channels will be set to the preset defaults" sentence in the notes section is technically correct, but I'm not against simplifying it if someone suggests a better wording. But note that's extra info for more advanced use cases. We may omit that bullet point entirely as the workings of the mixer will be described in the manual in much greater detail. I chose to include this extra detail in the notes section, but I'm still 50/50 whether it should stay or maybe we should rather just lose it.

In general, translating software only by looking at the list of string messages in isolation bullshit, that's not how translating software is done properly. Translators need to understand the features to do a proper job, preferably they need to be users of said software, there's no way around it. Otherwise you have no idea of the greater context. Anyone who volunteers to localise DOSBox Staging to a different language needs to understand this, otherwise you could just give the job to a random guy who speaks both languages but never used Staging, or DOS, or even a computer 😄 That would result in horrible translations, in general...


Chorus

image

Reverb

image

Crossfeed

image

@Grounded0
Copy link
Collaborator

Grounded0 commented Oct 27, 2023

Anyone messing around with the MIXER is probably at least a weekend audiophile and is expected to understand whats going on in above screenshots. Trying to translate highly technical projects like this is a challenge and is probably the reason there's not Finnish, Swedish, Danish or Norwegian translations of DOSBox Staging.

@johnnovak
Copy link
Member

Anyone messing around with the MIXER is probably at least a weekend audiophile and is expected to understand whats going on in above screenshots. Trying to translate highly technical projects like this is a challenge and is probably the reason there's not Finnish, Swedish, Danish or Norwegian translations of DOSBox Staging.

Thanks @Grounded0. Hence my mixed approach (no pun intended 😎 ): using the chorus, reverb and crossfeed settings with the presets is "easy mode". Most people (90%+) will get at least 80% of the benefits that way by just setting reverb = large etc.

Then if you go into audio-enthusiast territory, you need to understand things. But that's for the minority like myself, and things get slightly complex then. But most people can safely ignore the fine-tuning of the chorus/reverb/crossfeed stuff.

@kcgen
Copy link
Member

kcgen commented Oct 27, 2023

We may omit that bullet point entirely as the workings of the mixer will be described in the manual in much greater detail. I chose to include this extra detail in the notes section, but I'm still 50/50 whether it should stay or maybe we should rather just lose it.

I think this caveat can be snipped because new channels get the as-configured strength (not default):

Repro:

  1. Enable Chorus with a non-default strength (strong):

    2023-10-26_19-20

  2. Bring the CMS and Tandy PSG channels online (for the first time this session):

    2023-10-26_19-21

The caveat implies that these two new ("subsequently activated") channels would only get the default chorus strength (normal), but it's even better: they get the as-configured strength. 🥳

@johnnovak
Copy link
Member

johnnovak commented Oct 27, 2023

"Preset default" is what the help text says @kcgen. So yeah in your case whatever defaults strength the "strong" preset has.

If you set the chorus of all active channels with say "mixer c15", but then enable another mixer channel, that will get the default of the active (last set) preset.

All this is much clearer on a GUI, but we're dealing with a CLI interface here.

@kcgen
Copy link
Member

kcgen commented Oct 27, 2023

When I check the conf wording for Preset default, I see them here:

# chorus:
#   off:   No chorus (default).
#    on:   Enable chorus (normal preset).

It tells me the default is off. But when it's on, the preset strength is normal.

Preset is prior to setting (pre-set). After setting a specific strength, we're no longer in "preset" tense.

So yeah.. I would just eliminate that wording because this is behavior isn't a caveate or an exception.

The current [mixer] chorus strength is globally applied (whatever it might be.. off, on/normal, or a specific set strength), and it affects current and future channels equally.

The behavior is very intuitive and what one would expect, so having extra caveat-sounding wording might imply extra nuances when none is needed.

@johnnovak
Copy link
Member

johnnovak commented Oct 27, 2023

When I check the conf wording for Preset default, I see them here:

# chorus:
#   off:   No chorus (default).
#    on:   Enable chorus (normal preset).

It tells me the default is off. But when it's on, the preset strength is normal.

Preset is prior to setting (pre-set). After setting a specific strength, we're no longer in "preset" tense.

So yeah.. I would just eliminate that wording because this is behavior isn't a caveate or an exception.

The current [mixer] chorus strength is globally applied (whatever it might be.. off, on/normal, or a specific set strength), and it affects current and future channels equally.

The behavior is very intuitive and what one would expect, so having extra caveat-sounding wording might imply extra nuances when none is needed.

"Preset defaults" and "default preset" are two different things, but I admit the distinction will be lost on many people 😄 The nuance is still there, but ultimately we should not document every edge case-y behaviour in the setting descriptions so I'm happy to lose this extra note. This extra explanation has done more harm than good so far 😄

Feel free to raise a PR guys and convert to "notes section" into a "note" section for the 3 affected settings 😄

@Kappa971
Copy link
Contributor

Kappa971 commented Oct 27, 2023

"Preset default" is what the help text says @kcgen. So yeah in your case whatever defaults strength the "strong" preset has.

If you set the chorus of all active channels with say "mixer c15", but then enable another mixer channel, that will get the default of the active (last set) preset.

All this is much clearer on a GUI, but we're dealing with a CLI interface here.

It was enough to write this instead of the usual "read this", it was a simple answer that would help me and save me time (or is your time more precious than mine?).
Furthermore, this answer shows that that sentence only made sense in your head, because you were the one who developed that option and so you know what it can do and what it can't do.
I can translate the sentences but I can't guess what you think 😅.

My knowledge of English is limited, I can translate and understand sentences but if I don't understand something, well... we live in a world full of technology. In any case, I know Italian reasonably well and I'm not reluctant to learn new words in both languages, but in this sentence the problem was evidently not me.

If you find someone more competent than me, I will be happy to pass the baton.
If you think my job could be done better by you, then you're welcome.

When I check the conf wording for Preset default, I see them here:

# chorus:
#   off:   No chorus (default).
#    on:   Enable chorus (normal preset).

It tells me the default is off. But when it's on, the preset strength is normal.

Preset is prior to setting (pre-set). After setting a specific strength, we're no longer in "preset" tense.

So yeah.. I would just eliminate that wording because this is behavior isn't a caveate or an exception.

The current [mixer] chorus strength is globally applied (whatever it might be.. off, on/normal, or a specific set strength), and it affects current and future channels equally.

The behavior is very intuitive and what one would expect, so having extra caveat-sounding wording might imply extra nuances when none is needed.

Luckily there's @kcgen! 😄

@Grounded0
Copy link
Collaborator

190881084-6ce3b175-6cbd-428d-9d44-3f22d120c7d9

@Kappa971
Copy link
Contributor

Kappa971 commented Oct 27, 2023

I changed the sentences like this:

:CONFIG_CROSSFEED
  - The crossfeed strength of subsequently activated mixer channels will be
    adjusted according to the current preset.

:CONFIG_REVERB
  - Reverb levels of subsequently activated mixer channels will be adjusted
    according to the current preset.

:CONFIG_CHORUS
  - Chorus levels of subsequently activated mixer channels will be adjusted
    according to the current preset.

. . .

:SHELL_CMD_MIXER_HELP_LONG
  - The reverb and chorus commands also apply the default reverb and chorus
    values, respectively, to channels where these effects are not yet enabled.

@kklobe kklobe unpinned this issue Nov 13, 2023
@Burrito78
Copy link
Collaborator

Burrito78 commented Nov 22, 2023

@kcgen Can you update the DE translation file so that all new and edited sections get replaced with the EN text, please. You did that before on request and I think it's an automated process/easy to do, right?

@kcgen
Copy link
Member

kcgen commented Nov 23, 2023

Will do @Burrito78.

@kcgen
Copy link
Member

kcgen commented Nov 23, 2023

Here are the new messages for the:

Regarding modifications to existing messages, the latest updates are in: afd269d (this is the English sync)

Suggest downloading the full files from here: https://github.com/dosbox-staging/dosbox-staging/tree/kc/sync-translation-files-1/contrib/resources/translations and using the above as a quick reference. Then PR your updates (or attach here).

@FeralChild64
Copy link
Collaborator

FeralChild64 commented Nov 23, 2023

I’ll probably wait a week or two before updating the translation - looking at the pull requests, there are still some string changes going to be merged.

@johnnovak
Copy link
Member

@FeralChild64 Can we close this megaticket? The translation stuff is ongoing work, it's never finished.

@FeralChild64
Copy link
Collaborator

Sure, I don’t think it is needed anymore.

@Grounded0
Copy link
Collaborator

Spanish and Portuguese (Brazilian) were added without going through this ticket so it seems extraneous these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or enhancement of existing features good first issue Good for newcomers help wanted Community help wanted translation Issues related to translations
Projects
No open projects
0.77.0 release
  
Planned but not completed in 0.77
0.79 release
In progress
Development

No branches or pull requests

16 participants