-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mounting floppy/CD images via drag and drop #92
Comments
what about drag/drop of executables - maybe with auto-mount to exe-path? |
I see no reason why not :) It would be definitely very user-friendly feature. |
maybe too userfriendly:) |
This would be a big usability and feedback improvement! We could imgmount cue and ISO files as well (or multiple.. looking at you Wing Command 4) to similarly simplify one-time installs from CD. Indication of the mounted image (or cdrom label) would be so nice to see; and if it replaces "frameskip" then all the better, which has outgrown its value with today's faster systems. |
"Proof of concept" implementation can be found on the branch Some cleanup, refactoring and proper implementation are needed, but this implementation is testable already.
Having briefly tested it… it's so nice to have DOSBox behaving like a user-friendly app for a while ;) |
Nice work @dreamer in laying the foundation for drag n' drop! |
Some kind of GUI for mounting is badly needed. I have all of my CD images stored in Redump naming convention which means that their full paths are long. Having to type them out manually is insane, there needs to be a better way. |
I would have really liked if this was addressed, this is the only issue that's stopping me from using dosbox-staging over upstream, it's otherwise superior in several ways. |
@dreamer Any progress on this one? |
Drag'n'drop alone is probably not the best solution. IMHO, DosBox-staging could use a proper GUI where you could mount images, change settings, etc. Dosbox-X actually has such a GUI although its configuration interface is pretty barebones. |
Could we at least get auto-completion for IMGMOUNT command so that user doesn't have to type out the path completely manually? |
Its probably up to your COMMAND.COM. I use FreeCOM from FreeDOS and it autocompletes nicely: |
No, you misunderstand, DosBox shell itself does support auto-completion but it only works on files within DosBox's mounted filesystem, it does not work on host files. |
@dreamer Do you still think this is doable under Linux/Win/macOS without hackery? Still in-scope? I would love to have it, btw! |
Lots of weird comments here... Don't you use per-game configs with IMGMOUNT in your autoexec section, kids? 😄 |
Drag and drop is doable with floppy images. Multiple floppy images can be handled too. With CD images, I think we need the OSD features otherwise selecting the drive letter would be too ambiguous. A requester dialog should come up, asking for the drive letter the CD image should be mounted to. |
What about limiting mounting CD images via drag and drop to the next free drive letter after C? That is mostly correct on DOS machines and what most people will want. If you need something special, you have to mount via config/command line. |
I guess that could work too before the OSD is introduced. But the OSD requester approach is just superior IMO. |
IMHO, "next free drive letter after C" will be OK for the majority of the cases, so that can be the default/automatic behavior. Why answer an OSD requester when I can have my image automatically mounted to a sensible letter? OSD should have of course the option to manually mount to any letter (or maybe even move already mounted images to another letter - in case of mistakes, etc.), but drag-and-drop is better to be seamless? (...or having an OSD config setting choosing the drag-and-drop behavior) |
Good point, @Torinde, I'm convinced. Probably this would be the best:
|
That solves the question of "or having an OSD config setting choosing the drag-and-drop behavior", good! for completeness: HDD images/host folders - mount to first available letter after B (so, C or later, whichever is free)? |
Recently I installed Windows 3.11 inside dosbox-staging for testing, and nothing kills enthusiasm for installing older software then the necessity to juggle multiple floppy images. Especially if installer sometimes asks user to put in floppy out of order ("please insert this disk 5 out of 10").
It is totally possible to mount them alrady with
imgmount
and change with Ctrl+F4, but it is annoying due to lack of feedback.With SDL2 it should be possible to implement mounting via SDL_DropEvent, which should make it much easier to mount floppies selectively.
Additionally, we could leave some visual indication about mounted floppy by placing e.g.
A:<label>
in the title bar (and remove "frameskip" information to make room).The text was updated successfully, but these errors were encountered: