Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mounting floppy/CD images via drag and drop #92

Open
dreamer opened this issue Dec 13, 2019 · 21 comments
Open

Support mounting floppy/CD images via drag and drop #92

dreamer opened this issue Dec 13, 2019 · 21 comments
Assignees
Labels
DOS Issues related to DOS integration or DOS commands enhancement New feature or enhancement of existing features user interface Issues related to the user interface of DOSBox itself

Comments

@dreamer
Copy link
Member

dreamer commented Dec 13, 2019

Recently I installed Windows 3.11 inside dosbox-staging for testing, and nothing kills enthusiasm for installing older software then the necessity to juggle multiple floppy images. Especially if installer sometimes asks user to put in floppy out of order ("please insert this disk 5 out of 10").

It is totally possible to mount them alrady with imgmount and change with Ctrl+F4, but it is annoying due to lack of feedback.

With SDL2 it should be possible to implement mounting via SDL_DropEvent, which should make it much easier to mount floppies selectively.

Additionally, we could leave some visual indication about mounted floppy by placing e.g. A:<label> in the title bar (and remove "frameskip" information to make room).

@dreamer dreamer added the enhancement New feature or enhancement of existing features label Dec 13, 2019
@LowLevelMahn
Copy link
Collaborator

what about drag/drop of executables - maybe with auto-mount to exe-path?

@dreamer
Copy link
Member Author

dreamer commented Dec 13, 2019

I see no reason why not :) It would be definitely very user-friendly feature.

@LowLevelMahn
Copy link
Collaborator

maybe too userfriendly:)
console copy & paste is also very missing

@kcgen
Copy link
Member

kcgen commented Dec 14, 2019

Additionally, we could leave some visual indication about mounted floppy by placing e.g. A:<label> in the title bar (and remove "frameskip" information to make room).

This would be a big usability and feedback improvement! We could imgmount cue and ISO files as well (or multiple.. looking at you Wing Command 4) to similarly simplify one-time installs from CD.

Indication of the mounted image (or cdrom label) would be so nice to see; and if it replaces "frameskip" then all the better, which has outgrown its value with today's faster systems.

@dreamer
Copy link
Member Author

dreamer commented Dec 31, 2019

"Proof of concept" implementation can be found on the branch po/drag-drop-floppy-1 (see snapshot builds in attachments).

Some cleanup, refactoring and proper implementation are needed, but this implementation is testable already.

  • Works only for floppies (not for CD images nor executable files)
  • Only 1 floppy image can be drag'n'dropped at a time
  • Droping an image always targets drive A:
  • Droping an image unmounts previous image mounted in drive A
  • There is no visual feedback in the titlebar yet

Having briefly tested it… it's so nice to have DOSBox behaving like a user-friendly app for a while ;)

@kcgen
Copy link
Member

kcgen commented Dec 31, 2019

Nice work @dreamer in laying the foundation for drag n' drop!
(Looking forward to testing this when internet access to my home is restored)

@dreamer dreamer added this to New features in Backlog via automation Mar 28, 2020
@dreamer dreamer moved this from Suggested new features to Planned features in Backlog Mar 28, 2020
@dreamer dreamer self-assigned this Apr 1, 2020
@NicknineTheEagle
Copy link
Member

NicknineTheEagle commented Oct 1, 2020

Some kind of GUI for mounting is badly needed. I have all of my CD images stored in Redump naming convention which means that their full paths are long. Having to type them out manually is insane, there needs to be a better way.

@dreamer dreamer added this to To do in 0.77.0 release via automation Nov 15, 2020
@dreamer dreamer removed this from Planned features in Backlog Nov 15, 2020
@NicknineTheEagle
Copy link
Member

I would have really liked if this was addressed, this is the only issue that's stopping me from using dosbox-staging over upstream, it's otherwise superior in several ways.

@MasterO2
Copy link
Contributor

@dreamer Any progress on this one?

@NicknineTheEagle
Copy link
Member

NicknineTheEagle commented May 9, 2021

Drag'n'drop alone is probably not the best solution. IMHO, DosBox-staging could use a proper GUI where you could mount images, change settings, etc. Dosbox-X actually has such a GUI although its configuration interface is pretty barebones.

@kcgen kcgen moved this from To do to Unlikely to be done in 0.77 - will be moved to backlog soon in 0.77.0 release Jun 15, 2021
@kcgen kcgen added this to To do in 0.78 release Jul 3, 2021
@kcgen kcgen moved this from To do to Unlikely Tasks in 0.78 release Sep 30, 2021
@NicknineTheEagle
Copy link
Member

NicknineTheEagle commented Dec 18, 2021

Could we at least get auto-completion for IMGMOUNT command so that user doesn't have to type out the path completely manually?

@Grounded0
Copy link
Collaborator

Grounded0 commented Dec 18, 2021

Its probably up to your COMMAND.COM. I use FreeCOM from FreeDOS and it autocompletes nicely:

https://github.com/FDOS/freecom

@NicknineTheEagle
Copy link
Member

NicknineTheEagle commented Dec 19, 2021

Its probably up to your COMMAND.COM. I use FreeCOM from FreeDOS and it autocompletes nicely:

https://github.com/FDOS/freecom

No, you misunderstand, DosBox shell itself does support auto-completion but it only works on files within DosBox's mounted filesystem, it does not work on host files.

@Burrito78
Copy link
Collaborator

@dreamer Do you still think this is doable under Linux/Win/macOS without hackery? Still in-scope? I would love to have it, btw!

@johnnovak
Copy link
Member

Lots of weird comments here... Don't you use per-game configs with IMGMOUNT in your autoexec section, kids? 😄

@johnnovak
Copy link
Member

Drag and drop is doable with floppy images. Multiple floppy images can be handled too.

With CD images, I think we need the OSD features otherwise selecting the drive letter would be too ambiguous. A requester dialog should come up, asking for the drive letter the CD image should be mounted to.

@johnnovak johnnovak added user interface Issues related to the user interface of DOSBox itself enhancement New feature or enhancement of existing features DOS Issues related to DOS integration or DOS commands and removed enhancement New feature or enhancement of existing features labels Mar 28, 2024
@Burrito78
Copy link
Collaborator

Drag and drop is doable with floppy images. Multiple floppy images can be handled too.

With CD images, I think we need the OSD features otherwise selecting the drive letter would be too ambiguous. A requester dialog should come up, asking for the drive letter the CD image should be mounted to.

What about limiting mounting CD images via drag and drop to the next free drive letter after C? That is mostly correct on DOS machines and what most people will want. If you need something special, you have to mount via config/command line.

@johnnovak
Copy link
Member

Drag and drop is doable with floppy images. Multiple floppy images can be handled too.
With CD images, I think we need the OSD features otherwise selecting the drive letter would be too ambiguous. A requester dialog should come up, asking for the drive letter the CD image should be mounted to.

What about limiting mounting CD images via drag and drop to the next free drive letter after C? That is mostly correct on DOS machines and what most people will want. If you need something special, you have to mount via config/command line.

I guess that could work too before the OSD is introduced. But the OSD requester approach is just superior IMO.

@Torinde
Copy link
Contributor

Torinde commented Mar 29, 2024

IMHO, "next free drive letter after C" will be OK for the majority of the cases, so that can be the default/automatic behavior.

Why answer an OSD requester when I can have my image automatically mounted to a sensible letter? OSD should have of course the option to manually mount to any letter (or maybe even move already mounted images to another letter - in case of mistakes, etc.), but drag-and-drop is better to be seamless? (...or having an OSD config setting choosing the drag-and-drop behavior)

@johnnovak
Copy link
Member

Good point, @Torinde, I'm convinced.

Probably this would be the best:

  • Simple drag: mount file(s) as floppy image(s) in A:, or mount CD image(s) to the first available drive letter after C. If a CD-ROM mount already exists, swap the disc in the first CD-ROM drive instead.
  • Shift + drag: Bring up requester with options.

@Torinde
Copy link
Contributor

Torinde commented Mar 30, 2024

Shift + drag: Bring up requester with options.

That solves the question of "or having an OSD config setting choosing the drag-and-drop behavior", good!

for completeness: HDD images/host folders - mount to first available letter after B (so, C or later, whichever is free)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOS Issues related to DOS integration or DOS commands enhancement New feature or enhancement of existing features user interface Issues related to the user interface of DOSBox itself
Projects
No open projects
0.77.0 release
  
Planned but not completed in 0.77
0.78 release
Unlikely Tasks
Development

No branches or pull requests

9 participants