Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushState for Modals #109

Closed
DFurnes opened this issue Jan 30, 2014 · 0 comments
Closed

PushState for Modals #109

DFurnes opened this issue Jan 30, 2014 · 0 comments

Comments

@DFurnes
Copy link
Contributor

DFurnes commented Jan 30, 2014

Modals should support loading in content two different ways:

  1. Load in contents of a given URL via AJAX into a modal. If supported, update the page URL in the location bar and let the user hit the back button to get back to the original page. This should pass an X-PJAX header (or equivalent) to toggle whether containing layout is rendered or not.
  2. Load in contents from a pre-loaded element in the page by ID in data-id attribute. (current behavior)

If both are specified, load the pre-loaded div contents and use pushState to update the canonical URL without an AJAX request. This lets us "fake" loading the real page so the user can just copy the location in the address bar if they want to bookmark or share the link.

@DFurnes DFurnes modified the milestone: v3.1.0 Statisk Sep 17, 2014
@DFurnes DFurnes closed this as completed Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant