Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off by one in parallel #5

Open
tyldum opened this issue Sep 13, 2018 · 3 comments
Open

Off by one in parallel #5

tyldum opened this issue Sep 13, 2018 · 3 comments

Comments

@tyldum
Copy link
Contributor

tyldum commented Sep 13, 2018

Seems to be one more active connection than the one specified in ->max_active().

This is minor and I might get to send you a PR, but right now I just had to document it as I hurry on in my project ;)

For most people this would simply mean that UA will keep opening and closing one additional connection if max_active is set equal to max_connections.

Neat tshark command to summarize this when testing:
tshark -z endpoints,tcp,ip.addr==$serverip

@dotandimet
Copy link
Owner

off-by-one errors... :swears:

@dotandimet
Copy link
Owner

I wonder if this is a logic error or related to the memory leaks - something isn't releasing that extra connection.

@tyldum
Copy link
Contributor Author

tyldum commented Oct 9, 2018

If "active" is initialized to 1 it corresponds if "max_active" > 1.
However there are no connections if "active" is initialized to 1 and "max_active" is set to 1. Race condition on the first iteration?
Okay for my current use-case, hope to get time to revisit later.

Edit: Still there for 1.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants