-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand port type to accept a string #232
Comments
Thanks a lot for bringing this up @corydeppen. Just to clarify: When running the server via IIS under Windows the port will become a string? |
Correct, at least when the iisnode handler is used like in the case of Azure. |
Sounds good! Yeah, would be great to have a PR for this. |
I just ran into this! Glad to see its fixed already :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've run into an issue deploying a GraphQL server on Azure. Since iisnode is used to run Node apps, the port is assigned to a named pipe instead of a number (see tjanczuk/iisnode#46). As a result, I see an error
RangeError: "port" argument must be >= 0 and < 65536
when the server tries to run.I'm hoping you'll find it reasonable to modify the
port
definition in theOptions
interface to benumber | string
and removeparseInt
from the conditional when assigning theport
option in theGraphQLServer
class.I'm happy to submit a PR if you agree.
The text was updated successfully, but these errors were encountered: