Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix comparing benchmarks #424

Closed
wants to merge 1 commit into from
Closed

Conversation

mgrachev
Copy link
Member

@mgrachev mgrachev commented May 8, 2021

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #424 (d5693d2) into master (889636e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #424   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          38       38           
  Lines        2746     2747    +1     
=======================================
+ Hits         2719     2720    +1     
  Misses         27       27           
Impacted Files Coverage Δ
src/common/warning.rs 100.00% <100.00%> (ø)
src/lib.rs 98.54% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889636e...d5693d2. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 8, 2021

Benchmark for 3f3c540

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 66.6±6.87µs 63.4±4.59µs +5.05%
dotenv_linter compare 56.4±4.41µs 51.0±3.96µs +10.59%
dotenv_linter fix 236.9±283.09µs 188.8±13.88µs +25.48%
dotenv_linter fix with backup 238.5±15.50µs 288.2±472.74µs -17.24%

Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@github-actions
Copy link

github-actions bot commented May 8, 2021

Benchmark for fdcf9c5

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 75.2±5.01µs 74.3±4.73µs +1.21%
dotenv_linter compare 64.6±4.04µs 61.8±5.43µs +4.53%
dotenv_linter fix 194.5±16.18µs 213.8±20.74µs -9.03%
dotenv_linter fix with backup 260.8±24.35µs 273.3±73.96µs -4.57%

@mgrachev mgrachev added the do not merge Do not merge label May 31, 2021
@mgrachev mgrachev added the invalid This doesn't seem right label Jul 5, 2021
@mgrachev mgrachev closed this Jul 15, 2021
@mgrachev mgrachev deleted the fix-comparing-benchmarks branch July 15, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge invalid This doesn't seem right
Development

Successfully merging this pull request may close these issues.

None yet

2 participants