Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Vulnerability: https://github.com/advisories/GHSA-8g2p-5pqh-5jmc #80

Open
iduras3 opened this issue Nov 9, 2022 · 7 comments

Comments

@iduras3
Copy link

iduras3 commented Nov 9, 2022

A direct dependency has a vulnerability. vulnerability

@dotMorten
Copy link
Owner

I need a bit more info than that. This package doesn't use Microsoft.SqlServer.Types - it's an alternatice to that when not running on .net framework

@bjorngadde
Copy link

I believe it's this vulnerability: GHSA-8g2p-5pqh-5jmc.

This project references System.Data.SqlClient 4.8.3, which seems to be affected.

@dotMorten
Copy link
Owner

It’s an implicit reference. You can reference a newer version in your application

@bjorngadde
Copy link

Yes. Until the reference is bumped, one can explicitly override the version. Instructions can be found via the link above.

@dotMorten
Copy link
Owner

My point is this library doesn't ship the vulnerable library, so there's no vulnerability in this library.

@iduras3
Copy link
Author

iduras3 commented Nov 11, 2022

We have a dotnet 6 aspnet core project, where we have this package as a transitive dependency. This package shows that it has a dependency on the vulnerable package.

"dotMorten.Microsoft.SqlServer.Types": { "type": "Transitive", "resolved": "1.4.0", "contentHash": "MYxVbuBguObk8QFNTuBZ+ZEC/m1zbvG774FbFvwiDZjc0RYq/co27THrHN5Dyd52ie0R5bt2uxSZj4tIb3lYFg==", "dependencies": { "System.Data.SqlClient": "4.8.3", "System.Memory": "4.5.4" }

I can see that the System.Data.SqlClient package with that version is in the csproj file.

@dotMorten
Copy link
Owner

Yes it’s a dependency you can override by adding an explicit reference. You’re not using the 2.x release which uses the newer sql client libraries. The 1.x releases are just there for old compat with the older client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants