Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

eShopLegacyWebForms does not compile #57

Closed
PRudykIteo opened this issue Feb 16, 2021 · 4 comments
Closed

eShopLegacyWebForms does not compile #57

PRudykIteo opened this issue Feb 16, 2021 · 4 comments
Assignees
Labels

Comments

@PRudykIteo
Copy link
Contributor

I found this project during MS Learn Tutorial: https://docs.microsoft.com/pl-pl/learn/modules/aspnet-session/
During exercise I was told to download project from this repository. As stated in instructions, VS asked me to install additional components. During all this time, solution did not compile.
Unfortunately VS provided only ambiguous messages about missing or conflicting packages without any error code. However, after some research, I was able to fix this error by downgrading log4net nuget package to 2.0.8.0.
I can prepare a pull request if needed.

@anirugu
Copy link

anirugu commented Mar 4, 2021

same here, tried to build on 2 machine. installed the .net 4.7.2 which is missing on 1 machine. doesn't work on any of both.

Can someone look into this matter.

@sughosneo
Copy link
Contributor

Hi @PRudykIteo / @anirugu - thank you for reaching out and reporting this behavior. Will test and update.

@sughosneo sughosneo added the bug label Mar 5, 2021
@sughosneo
Copy link
Contributor

Hey @PRudykIteo, yes, your analysis was correct. 👍 There is some issue with the log4net package. Actually, within the src\eShopLegacyWebForms\eShopLegacyWebForms.csproj file package is still pointing to the old version 2.0.8.
And that's the reason if you downgrade the log4net, then the project gets build successfully. My suggestion would be, let's update the solution with log4net version as 2.0.10`.

You could submit a PR with the changes. We will be happy to review and merge the changes with the main branch.

Thank you.

@sughosneo
Copy link
Contributor

This issue has been fixed. So closing it. Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants