Refactor CreateOrder() MVC Controller

[CESARDELATORRE]

Need to refactor. Our current implementation is:

    [Route("new")]
    [HttpPost]
    public async Task<IActionResult> CreateOrder([FromBody]CreateOrderCommand createOrderCommand)
    {
        if (createOrderCommand.CardTypeId == 0)
        {
            createOrderCommand.CardTypeId = 1;
        }
        createOrderCommand.BuyerIdentityGuid = _identityService.GetUserIdentity();

        var result = await _mediator.SendAsync(createOrderCommand);
        if (result)
        {
            return Ok();
        }
        return BadRequest();
    }

1. We need to move the obtention of the identity to the CommandHandler, so the Command could be Immutable as we won't need to update the Identity into the Command object
   _identityService.GetUserIdentity();
   This issue is related to issue Make immutable Commands and remove behavior from the Command classes - i.e. CreateOrderCommand #36 - Make immutable Commands and remove behavior from the Command classes - i.e. CreateOrderCommand #36

2. The validations of the command could be done based on a MediatR Decorator Pattern, instead of a control sentence within the controller. See:
   Validating Commands with the Decorator Pattern
   http://codeopinion.com/validating-commands/

So the final controller should look like this:

    [Route("new")]
    [HttpPost]
    public async Task<IActionResult> CreateOrder([FromBody]CreateOrderCommand createOrderCommand)
    {
        var result = await _mediator.SendAsync(createOrderCommand);
        if (result)
        {
            return Ok();
        }
        return BadRequest();
    }

[ardalis]

Agreed.

[eiximenis]

Done in commit 67ab115

In branch vs2017

[CESARDELATORRE]

Solved. Closing it.