Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme is not automatically updated #98

Open
RodBarnes opened this issue Nov 30, 2022 · 6 comments
Open

Dark theme is not automatically updated #98

RodBarnes opened this issue Nov 30, 2022 · 6 comments

Comments

@RodBarnes
Copy link

RodBarnes commented Nov 30, 2022

I've completed the workshop and implemented the AppThemes section, but the app doesn't pick up the change except when starting. Specifically, I can run the app -- it comes up in light theme styles. Then, change the device to Dark Theme -- but the app doesn't change. If I close the app and then re-open it, it picks up the theme change then and displays the dark theme styles. I've gone back through the section and compared to the "Finish" project but can't see anything I've done differently.

@jamesmontemagno
Copy link
Collaborator

Which OS specifically?

Does the finish project work or no?

@bgaprogrammer
Copy link

Which OS specifically?

Does the finish project work or no?

I did see the same issue for both Windows and Mac OS (in fact I reported it to you throught Mastodon) no matter the project folder (chapter 1... N) and also the Finish one. All of them fails.

@jamesmontemagno
Copy link
Collaborator

Gotcha! Testing it out here, i think something is broke perhaps in the most recent release... testing out.

@RodBarnes
Copy link
Author

RodBarnes commented Dec 6, 2022

(Sorry for the delayed response.) I first noticed it on Android but it affects Windows, too.

Were you able to duplicate this? It looks correct as I've walked through the code and read the docs on theming. Maybe a defect in the generated code?

@jamesmontemagno
Copy link
Collaborator

I am going to double check. It looks like there is an open bug. Everythign works well for me on Windows, but Android does not. The team is looking into it right now dotnet/maui#11299

@towianisci
Copy link

Yep ,I'm running into the same bug. Great course though.
The theme will only update if you close the application and re-open it after making the system change from one team to the other. It's almost as if it's not receiving notification of change for system theme.

https://learn.microsoft.com/en-us/dotnet/maui/user-interface/system-theme-changes?view=net-maui-7.0

I'm developing on the macOS system. Trade it as a desktop app an iOS app, and a android app. Each did not change the mean when system change the mean for the various OSs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants