Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorizationFilterContext no longer relevant in .NET Core 3.0 #15263

Closed
IGx89 opened this issue Oct 22, 2019 — with docs.microsoft.com · 7 comments
Closed

AuthorizationFilterContext no longer relevant in .NET Core 3.0 #15263

IGx89 opened this issue Oct 22, 2019 — with docs.microsoft.com · 7 comments
Labels
doc-enhancement Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

Copy link

IGx89 commented Oct 22, 2019

The last section in these docs talks about using AuthorizationFilterContext in HandleRequirementAsync, but context.Resource doesn't appear to be AuthorizationFilterContext anymore in .NET Core 3. See dotnet/aspnetcore#11075. I would love to see updated documentation for .NET Core 3 showing specifically how to access RouteData -- currently migrating a 2.2 webapp to 3.0 and that's one of the issues that came up.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@dotnet-bot dotnet-bot added ⌚ Not Triaged Source - Docs.ms Docs Customer feedback via GitHub Issue labels Oct 22, 2019
@Rick-Anderson
Copy link
Contributor

@serpent5 I thought we updated this but must have been another doc.

@Rick-Anderson
Copy link
Contributor

@IGx89 Was this addressed in https://github.com/aspnet/AspNetCore.Docs/pull/15103/files - which got brought over to #15120
cc @damienbod

@IGx89
Copy link
Author

IGx89 commented Oct 22, 2019

Not that I could see. That seemed to be focused on updating just the sample app, which doesn't access the MVC request context anywhere.

@serpent5
Copy link
Contributor

This is being discussed in #12564. There's some sample code in a draft PR against that issue, but it's awaiting feedback on whether or not that is the recommended approach.

@Rick-Anderson
Copy link
Contributor

Draft PR being #15218

@IGx89
Copy link
Author

IGx89 commented Oct 22, 2019

Thanks! I'll add a comment on that PR with an example. So far from playing with its code, it doesn't appear to demonstrate a way to access RouteData yet.

@Rick-Anderson
Copy link
Contributor

Moved to #16191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-enhancement Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants