Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Link in .NET Core 3 and later? #16297

Closed
xudonax opened this issue Dec 21, 2019 — with docs.microsoft.com · 10 comments · Fixed by #16480
Closed

Browser Link in .NET Core 3 and later? #16297

xudonax opened this issue Dec 21, 2019 — with docs.microsoft.com · 10 comments · Fixed by #16480
Assignees
Labels
doc-enhancement Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

Copy link

xudonax commented Dec 21, 2019

The start of the page talks about .NET Core 2.0 and 2.1, and the referenced package (Microsoft.VisualStudio.Web.BrowserLink) hasn't been updated since March 2018. Is this still a thing in .NET Core 3 and later?


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@dotnet-bot dotnet-bot added ⌚ Not Triaged Source - Docs.ms Docs Customer feedback via GitHub Issue labels Dec 21, 2019
@Rick-Anderson
Copy link
Contributor

@mkArtakMSFT can we retire this browser link article?

@scottaddie
Copy link
Member

@jodavis What's the current state of BrowserLink?

@softlion
Copy link

softlion commented Jan 8, 2020

Why no answer ... hard question ?

Copy link

softlion commented Jan 8, 2020

@jodavis
Copy link

jodavis commented Jan 8, 2020

@scottaddie Browser Link still works in .NET Core 3.

The package hasn't been updated because it only contains the hooks that Visual Studio uses to interact with the server. All the functional updates and bug fixes that have been needed are in Visual Studio itself.

Please don't remove the article. Visual Studio has fwlinks to it.

@softlion
Copy link

softlion commented Jan 8, 2020

I confirm that it works fine.
You must add the NuGet package Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation
and a call to services.AddMvc().AddRazorRuntimeCompilation(); and app.UseBrowserLink();

@scottaddie scottaddie added this to To do in January 2020 via automation Jan 8, 2020
@scottaddie scottaddie self-assigned this Jan 8, 2020
@scottaddie scottaddie moved this from To do to In progress in January 2020 Jan 8, 2020
@scottaddie
Copy link
Member

@softlion That makes sense because Razor runtime compilation is an opt-in feature as of ASP.NET Core 3.0. It was removed from the shared framework because of the dependency on Roslyn, which was also removed from the shared framework. See https://docs.microsoft.com/aspnet/core/migration/22-to-30?view=aspnetcore-3.1&tabs=visual-studio#opt-in-to-runtime-compilation for more info.

I'll apply the necessary 3.0 updates to the doc.

@scottaddie
Copy link
Member

@jodavis FYI, BrowserLink isn't working for me at all. See the issue I've logged at aspnet/BrowserLink#104.

@jodavis
Copy link

jodavis commented Jan 8, 2020

@scottaddie I'll follow up on your issue in aspnet/BrowserLink#104.

@scottaddie scottaddie added the 3.0 label Jan 9, 2020
January 2020 automation moved this from In progress to Done Jan 9, 2020
Copy link

Tidy1 commented Jan 30, 2020

I used @softlion method and it fixed my browser link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-enhancement Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
No open projects
January 2020
  
Done
Development

Successfully merging a pull request may close this issue.

7 participants