Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit OpenAPI doc #32634

Merged
merged 15 commits into from
May 23, 2024
Merged

Edit OpenAPI doc #32634

merged 15 commits into from
May 23, 2024

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented May 22, 2024

@Rick-Anderson Rick-Anderson marked this pull request as draft May 22, 2024 19:43
@Rick-Anderson Rick-Anderson changed the title move customize endpt earlier in doc Edit OpenAPI doc May 22, 2024
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Outdated Show resolved Hide resolved
aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Outdated Show resolved Hide resolved
aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Outdated Show resolved Hide resolved
aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Outdated Show resolved Hide resolved
aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Outdated Show resolved Hide resolved
aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Outdated Show resolved Hide resolved
aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Outdated Show resolved Hide resolved
aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Outdated Show resolved Hide resolved
aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Outdated Show resolved Hide resolved
aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Outdated Show resolved Hide resolved
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
@Rick-Anderson Rick-Anderson marked this pull request as ready for review May 23, 2024 18:41
@Rick-Anderson Rick-Anderson enabled auto-merge (squash) May 23, 2024 18:41
@Rick-Anderson Rick-Anderson merged commit a9d7b32 into main May 23, 2024
3 checks passed
@Rick-Anderson Rick-Anderson deleted the moveH2s branch May 23, 2024 18:42
Rick-Anderson added a commit that referenced this pull request May 23, 2024
* move customize endpt earlier in doc

* Update aspnetcore/release-notes/aspnetcore-9/samples/OpenApiExample/OpenApiExample.csproj

* Update aspnetcore/release-notes/aspnetcore-9/samples/OpenApiExample/OpenApiExample.csproj

* move customize endpt earlier in doc

* move customize endpt earlier in doc

* move customize endpt earlier in doc

* move customize endpt earlier in doc

* move customize endpt earlier in doc

* move customize endpt earlier in doc

* move customize endpt earlier in doc

* move customize endpt earlier in doc

* move customize endpt earlier in doc

* move customize endpt earlier in doc

* move customize endpt earlier in doc

* Apply suggestions from code review



---------

Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
@captainsafia
Copy link
Member

@Rick-Anderson @tdykstra This PR removed the install instructions from the Microsoft.AspNetCore.OpenApi package from the documentation. It's an important part of the setup. Can we revert this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OpenAPI doc with new code and edit pass
4 participants