Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new doc article on handling server side and client side culture on ASP.NET #8585

Closed
3 tasks
eriawan opened this issue Sep 18, 2018 · 59 comments
Closed
3 tasks
Assignees
Milestone

Comments

@eriawan
Copy link
Member

eriawan commented Sep 18, 2018

Describe the new topic

Abstract

Items to track

  • Handle client-side (user agent's) culture from server side culture and sample code
  • Handle client-side (user agent's) culture from client-side culture handling and sample code, using AcceptLanguageHeaderRequestCultureProvider in combination with jQuery
  • Use validation sample as another sample case with code

NOTES: other contents will be added later

cc @Rick-Anderson

I welcome feedback 🙂

@hishamco
Copy link
Member

Describe server-side culture feature in ASP.NET Core 2.1 and handling them (with sample code)

If you mean providing culture using IRequestCultureProvider the current docs already describes this, also AcceptLanguageHeaderRequestCultureProvider described there, i'm not sure what you will add, but I write my comments later

thanks

@eriawan
Copy link
Member Author

eriawan commented Sep 18, 2018

@hishamco

Thanks!
Yes, current doc already describes that. I may as well add the needed case on client side while also add more detail on server side. My WIP may or may not be in the form of new page.

@hishamco
Copy link
Member

I may as well add the needed case on client side while also add more detail on server side

Could you please elaborate?

@eriawan
Copy link
Member Author

eriawan commented Sep 18, 2018

I mean, for client side I will try to integrate with the previous problem when handling with jquery validation, and also try to have one sample that has handling for both server-side and client-side culture.

@Rick-Anderson Rick-Anderson changed the title [WIP] Create new doc article on handling server side and client side culture on ASP.NET Core 2.1 Create new doc article on handling server side and client side culture on ASP.NET Core 2.1 Sep 19, 2018
@Rick-Anderson
Copy link
Contributor

@ryanbrandenburg please review outline.

@ryanbrandenburg
Copy link
Contributor

By outline do you mean the items under the abstract heading? What's there is fine, but it doesn't give me much of an idea of what the doc will look like or say.

@Rick-Anderson
Copy link
Contributor

@eriawan go ahead.

@eriawan
Copy link
Member Author

eriawan commented Sep 25, 2018

@Rick-Anderson
thanks! I will start tomorrow.

@Rick-Anderson Rick-Anderson added this to the Backlog milestone Sep 26, 2018
@ryanbrandenburg
Copy link
Contributor

Seems like this is on @eriawan's plate now. If there was still an action item for me here re-assign me with a description of what needs done.

@Rick-Anderson
Copy link
Contributor

Thanks @ryanbrandenburg just wanted to verify you were OK with the plan.

@eriawan
Copy link
Member Author

eriawan commented Oct 5, 2018

Yes, the work is still ongoing.
I have updated the abstract above to indicate that the page will describe and emphasize handling client-side culture from server-side and client side.

@hishamco
Copy link
Member

hishamco commented Oct 5, 2018

@eriawan can create a WIP PR so we can see what's going on, also it's good to get the feedback at the early stages

@eriawan
Copy link
Member Author

eriawan commented Oct 6, 2018

@hishamco
I agree, thanks for the help 🙂
yes, I will put the PR after I finish testing my code against some web browsers first.

@Rick-Anderson Rick-Anderson added Pri1 High priority, do before Pri2 and Pri3 Pri2 Priority 2 labels Oct 19, 2018
@hishamco
Copy link
Member

@eriawan any update on this?

@eriawan
Copy link
Member Author

eriawan commented Nov 28, 2018

@hishamco

hang on, my testing to many web browsers about this feature is done, also because I've also tested the upgrade to .net core 2.1.500 SDK and test on it too. I'm alsoe adding some highlights comparing to core 2.0.

I'll push it soon within next week, please be patient 🙂

@FFMartin
Copy link

@eriawan
Any update on the subject ?

@eriawan
Copy link
Member Author

eriawan commented Jan 14, 2019

@FFMartin
testing is done! the page will be ready, with additional info for .NET Core 2.2 to keep up with.
please be patient 🙂

@dotVip
Copy link

dotVip commented Feb 13, 2019

Any update on the subject ?

@eriawan
Copy link
Member Author

eriawan commented Feb 15, 2019

@dotVip

The article will be ready around end February, with samples on .NET Core 2.1 and 2.2 and interop with server side. Please be patient 🙂

@Rick-Anderson
Copy link
Contributor

@eriawan I wouldn't worry about 2.1

@Rick-Anderson Rick-Anderson changed the title Create new doc article on handling server side and client side culture on ASP.NET Core 2.1 Create new doc article on handling server side and client side culture on ASP.NET Core 2.2 Feb 15, 2019
@guillos
Copy link

guillos commented Mar 9, 2019

Any Update? I´m stuck on this and don´t know what to do...

@eriawan
Copy link
Member Author

eriawan commented Dec 4, 2019

@Rick-Anderson
yes, I think 3.1 is better and it should be not much different on 5.0.

thanks for your patience! I'm still testing it, especially on the latest Chrome, Firefox and MS Edge beta that uses Chromium.

@Rick-Anderson
Copy link
Contributor

@dannevesdantas always looking for help.

@hishamco
Copy link
Member

hishamco commented Dec 4, 2019

Me too 😄, but I'm not sure why this takes so long, without any draft?!!

@dannevesdantas
Copy link
Contributor

Can we help in some way @eriawan? Do you need some help?

@hishamco
Copy link
Member

@eriawan any updates on this one, could you please push a draft PR, so we can help you

@eriawan
Copy link
Member Author

eriawan commented Feb 26, 2020

@hishamco

please be patient, I'm still migrating the code to .NET Core 3.1

@hishamco
Copy link
Member

My intend to help you nothing else, coz this issue takes long time

@ericvb
Copy link

ericvb commented Apr 24, 2020

What is the current status?

@hishamco
Copy link
Member

Any progress on this one?

1 similar comment
@hishamco

This comment was marked as duplicate.

@Rick-Anderson Rick-Anderson changed the title Create new doc article on handling server side and client side culture on ASP.NET Core 2.2 Create new doc article on handling server side and client side culture on ASP.NET Feb 24, 2022
@Rick-Anderson
Copy link
Contributor

@eriawan anything we can do to help? .NET 6 is all we need.

@eriawan
Copy link
Member Author

eriawan commented Feb 25, 2022

@Rick-Anderson

My bad, I apologize.
Let me revisit and try to come up wip in a week.

@hishamco
Copy link
Member

I suggest to send WIP PR, we can all help you on this

@Rick-Anderson Rick-Anderson removed Pri1 High priority, do before Pri2 and Pri3 Pri2 Priority 2 labels Mar 11, 2022
@Rick-Anderson
Copy link
Contributor

@eriawan anything we can do to help? .NET 7 is all we need.

@hishamco
Copy link
Member

hishamco commented Oct 1, 2022

This issues has no progress since 4 years unless there's a local branch doesn't push, again anything we can help you?

@eriawan
Copy link
Member Author

eriawan commented Oct 1, 2022

@Rick-Anderson
I'm deeply sorry I had taken this too long and I also I had to switch jobs during pandemic.
I have had work this on my work for .NET 6 and as suggested, I'm goiing to continue to put for .NET 7.
For .NET 7 I should use VS 2022 17.4 Preview with .NET 7 SDK Preview, right?

@Rick-Anderson
Copy link
Contributor

For .NET 7 I should use VS 2022 17.4 Preview with .NET 7 SDK Preview, right?

I'm on Version 17.4.0 Preview 2.0 today. Use the most current version.

@Rick-Anderson
Copy link
Contributor

@eriawan Just use .NET 7.

@hishamco
Copy link
Member

hishamco commented Feb 8, 2023

Could you please post a WIP PR, this took more than two years

@Rick-Anderson
Copy link
Contributor

@eriawan any ETA. You can use .NET 8

@hishamco
Copy link
Member

hishamco commented Feb 1, 2024

@Rick-Anderson this has taken too long, is there anything here to help you with?

@Rick-Anderson
Copy link
Contributor

I'll close the issue. IF @eriawan makes a PR, we can re-open.

@Ragowit
Copy link

Ragowit commented Feb 2, 2024

I really hope to see an update, since culture/localization is very important to all of us with more then just English as language. But yeah, it's been 6 years now...

@hishamco
Copy link
Member

hishamco commented Feb 2, 2024

@Ragowit is there anything in particular you need to update?

@Ragowit
Copy link

Ragowit commented Feb 2, 2024

@hishamco I have switched job over the last six years so I don't work with ASP.NET anymore. But I'm still keeping an eye on this out of interest.

@hishamco
Copy link
Member

hishamco commented Feb 2, 2024

All the best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests