Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarkdownExporter.Default.ExportToLog fails with NRE for Summary with Critical Validation Errors #152

Closed
ig-sinicyn opened this issue May 2, 2016 · 1 comment
Closed

MarkdownExporter.Default.ExportToLog fails with NRE for Summary with Critical Validation Errors #152

ig-sinicyn opened this issue May 2, 2016 · 1 comment
Labels
bug
Milestone
v0.9.6

Comments

@ig-sinicyn
Copy link
Contributor

Bench.Net 0.9.5, summary obtained from run with critical errors (e.g. run with Validators.JitOptimizationsValidator.FailOnError on debug build).

Call to the MarkdownExporter.Default.ExportToLog() fails at MarkdownExporter.PrintTable(), as the SummaryTable passed is null.
@adamsitnik adamsitnik added the bug label May 2, 2016
@adamsitnik adamsitnik added this to the v0.9.6 milestone May 2, 2016
@adamsitnik adamsitnik self-assigned this May 2, 2016
@adamsitnik adamsitnik changed the title NullReferenceException on MarkdownExporter.Default.ExportToLog() MarkdownExporter.Default.ExportToLog fails with NRE for Summary with Critical Validation Errors May 2, 2016
@adamsitnik
Copy link
Member

Honestly I am not sure if it was a bug, because BenchmarkRunner would not call any export if summary has some critical validation errors but I have fixed it anyway ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.9.6
Development

No branches or pull requests
3 participants
@AndreyAkinshin @adamsitnik @ig-sinicyn