Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msbuild binlog for the benchmark projects gets cleaned up too, making diagnosis of build impossible #2252

Closed
radical opened this issue Jan 19, 2023 · 2 comments · Fixed by #2254
Assignees
Milestone

Comments

@radical
Copy link
Member

radical commented Jan 19, 2023

If you use --generateBinLog for wasm benchmarks, you get:

/home/helixbot/work/B78C09A9/p/dotnet/dotnet  restore --packages "/home/helixbot/work/B78C09A9/w/BCE609B9/e/performance/artifacts/packages" /p:UseSharedCompilation=false /p:BuildInParallel=false /m:1 /p:Deterministic=true /p:Optimize=true
  -bl:8b197aae-5d64-4019-b6f4-46946d02dc65-restore.binlog

in /home/helixbot/work/B78C09A9/w/BCE609B9/e/performance/artifacts/bin/for-running/MicroBenchmarks/8b197aae-5d64-4019-b6f4-46946d02dc65

The binlog gets generated in /home/helixbot/work/B78C09A9/w/BCE609B9/e/performance/artifacts/bin/for-running/MicroBenchmarks/8b197aae-5d64-4019-b6f4-46946d02dc65, but that is getting cleaned up at the end, thus it is not retrievable later for diagnosis.

It would be useful to maybe use some path in artifacts which does not get removed for these files.

cc @adamsitnik

@radical
Copy link
Member Author

radical commented Jan 20, 2023

And related to that, a command line parameter to skip the cleanup would be useful too.

@adamsitnik
Copy link
Member

a command line parameter to skip the cleanup would be useful too.

We already have that: --keepFiles

I've sent #2254 which basically enables that when --generateBinLog is requested

@adamsitnik adamsitnik self-assigned this Jan 20, 2023
@adamsitnik adamsitnik added this to the v0.13.5 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants