Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark fails build with imported project #2391

Closed
mwadams opened this issue Aug 4, 2023 · 2 comments
Closed

Benchmark fails build with imported project #2391

mwadams opened this issue Aug 4, 2023 · 2 comments
Milestone

Comments

@mwadams
Copy link

mwadams commented Aug 4, 2023

As of v0.13.6, benchmark projects with an import like this fail to build and run.

This works fine on v0.13.5.

Workaround: Specify v0.13.5

<Project Sdk="Microsoft.NET.Sdk">
	<Import Project="$(EndjinProjectPropsPath)" Condition="$(EndjinProjectPropsPath) != ''" />

	<PropertyGroup>
		<OutputType>Exe</OutputType>
		<TargetFramework>net7.0</TargetFramework>
		<ImplicitUsings>enable</ImplicitUsings>
		<Nullable>enable</Nullable>
		<IsPackable>false</IsPackable>
	</PropertyGroup>

	<ItemGroup>
		<PackageReference Include="BenchmarkDotNet" Version="0.13.6" />
		<PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.13.6" />
		<PackageReference Include="Endjin.RecommendedPractices.GitHub" Version="2.1.5">
			<PrivateAssets>all</PrivateAssets>
			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
		</PackageReference>
	</ItemGroup>

	<PropertyGroup>
		<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
		<RestoreLockedMode Condition="$(ContinuousIntegrationBuild) == 'true'">true</RestoreLockedMode>
	</PropertyGroup>
</Project>
@adamsitnik
Copy link
Member

Hi @mwadams

Could you please try 0.13.7, it was released minutes after you posted the issue. It contains #2365 which should solve the problem. Thanks!

@mwadams
Copy link
Author

mwadams commented Aug 4, 2023

Yup! That does the trick.

@mwadams mwadams closed this as completed Aug 4, 2023
@AndreyAkinshin AndreyAkinshin added this to the v0.13.7 milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants