Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildImageFromDockerfileAsync is passing AuthConfigs not as Header X-Registry-Config. #417

Open
jehof opened this issue Sep 20, 2019 · 0 comments

Comments

@jehof
Copy link

jehof commented Sep 20, 2019

According to the documentation of the Docker API the AuthConfigs for other registries need to be passed as Header X-Registry-Config (https://docs.docker.com/engine/api/v1.40/#operation/ImageBuild), but they are passed as normal parameters (https://github.com/microsoft/Docker.DotNet/blob/5cb89ed1c8630d8c2077135e4048290076f808f0/src/Docker.DotNet/Endpoints/ImageOperations.cs#L46)

https://github.com/microsoft/Docker.DotNet/blob/5cb89ed1c8630d8c2077135e4048290076f808f0/src/Docker.DotNet/Models/ImageBuildParameters.Generated.cs#L73

We currently have the issue, that images are pulled from global docker registry, but not from out internal docker registry (even if we are logged in to the registry). Is seems that BuildImageFromDockerfileAsync needs explicit registry auth information. See also https://docs.docker.com/engine/api/v1.40/#section/Authentication

@jehof jehof changed the title BuildImageFromDockerfileAsync is passing AuthConfigs not correctly. BuildImageFromDockerfileAsync is passing AuthConfigs not as Header X-Registry-Config. Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant