Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EF6, EF5, and EF4.3.1 API reference to Docs #26

Open
divega opened this issue Aug 2, 2018 · 7 comments
Open

Move EF6, EF5, and EF4.3.1 API reference to Docs #26

divega opened this issue Aug 2, 2018 · 7 comments
Assignees

Comments

@divega
Copy link
Contributor

divega commented Aug 2, 2018

The API references for the non-core versions of the NuGet package should be part of the .NET API Browser. I talked to @dend and apparently they can be hosted in this repo.

To have complete coverage we discussed having the API reference generated for the following EntityFramework package versions:

Current locations which need to be redirected

@divega
Copy link
Contributor Author

divega commented Nov 12, 2018

@sudeepku you can close this issue as fixed once you finish with publishing the new API docs and the redirects.

Also, remember to let me know when it is done so I can update the links in our conceptual doc pages.

@divega
Copy link
Contributor Author

divega commented Nov 29, 2018

The API reference of EF 6 at https://docs.microsoft.com/en-us/dotnet/api/?view=entity-framework-6.2.0, but other versions are still empty:

https://docs.microsoft.com/en-us/dotnet/api/?view=entity-framework-5.0.0

https://docs.microsoft.com/en-us/dotnet/api/?view=entity-framework-4.3.1

Also the redirects on the old API references on MSDN are still needed.

cc @dend @Sampy @sudeepku

@divega
Copy link
Contributor Author

divega commented Dec 10, 2018

@dendeli-msft @sudeepku @Sampy, FYI, EF 5.0.0 and 4.3.1 APIs are still missing in the API browser.

@Sampy
Copy link

Sampy commented Dec 10, 2018

Looking at the contents of the live branch, I don't see any files in the FrameworksIndex folder for any version other than 6. You can see this on docs itself if you go to a page for entity framework and try to change the version for example: https://docs.microsoft.com/en-us/dotnet/api/system.data.entity?view=entity-framework-6.2.0. Unless System.Data.Entity is only defined in 6.2.0 and I picked a bad page, this means no part of docs knows about any version other than 6.2.0 since this repo doesn't define documentation for those versions.

The problem is deeper than the API Browser not showing them. Docs currently only has pages for the 6.2.0 release it seems.

@mairaw
Copy link
Contributor

mairaw commented Dec 19, 2018

I only see 6.2 in the FrameworksIndex folder as well:
https://github.com/aspnet/EntityFramework.ApiDocs/tree/live/EF/xml/FrameworksIndex

Probably the other monikers shouldn't be live until the content is there.

@smitpatel
Copy link
Member

Tagging @ajcvickers

We have docs for EF 6.2/5.0/4.3.1 & SqlCompact for 6.2 only. (files here https://github.com/aspnet/EntityFramework.ApiDocs/tree/live/EF/xml/FrameworksIndex)

From

Current locations which need to be redirected
EF6
https://msdn.microsoft.com/library/dn223258(v=vs.113).aspx (our conceptual docs point here)
https://msdn.microsoft.com/en-us/library/mt154346(v=vs.113).aspx (duplicate)
EF5
https://msdn.microsoft.com/en-us/library/hh289362(v=vs.103).aspx

First link is 404.
2nd redirects correctly
3rd still points to MSDN docs.

Also should we publish docs for EF 6.3?

@mairaw
Copy link
Contributor

mairaw commented Oct 8, 2019

What are the targets for 1st and 3rd? I can work with you offline with the team that is handling redirections.

@smitpatel smitpatel self-assigned this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants