You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implementation of the ParentEnumerator.MoveNext method in ManagedGit contains a small typo, which leads to incorrect behavior and System.ArgumentOutOfRangeException while iterating when number of commit's parents is greater than 2:
A non-strict inequality there should be replaced with a strict one.
I have opened a PR #693 which fixes the typo and adds a corresponding test. I'm testing against a real commit from mono/mono repository: mono/mono@ab39e8a.
It is a quite old commit from the times when merge strategy allowed commits to have three parents.
The text was updated successfully, but these errors were encountered:
Implementation of the
ParentEnumerator.MoveNext
method inManagedGit
contains a small typo, which leads to incorrect behavior andSystem.ArgumentOutOfRangeException
while iterating when number of commit's parents is greater than 2:Nerdbank.GitVersioning/src/NerdBank.GitVersioning/ManagedGit/GitCommit.cs
Line 167 in 6f656c3
A non-strict inequality there should be replaced with a strict one.
I have opened a PR #693 which fixes the typo and adds a corresponding test. I'm testing against a real commit from mono/mono repository: mono/mono@ab39e8a.
It is a quite old commit from the times when merge strategy allowed commits to have three parents.
The text was updated successfully, but these errors were encountered: