Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense tooltip for SqlCommand's CommandTimeout doesn't describe units #33

Closed
netdragonboberb opened this issue Dec 14, 2017 · 3 comments
Labels
💡 Enhancement New feature request

Comments

@netdragonboberb
Copy link

The Visual Studio tooltip for SqlCommand.CommandTimeout doesn't say whether units are seconds or milliseconds.The tooltip says "Gets or sets the wait time before terminating the attempt to execute a command and generating an error."

MSDN has a bettter description: "The time in seconds to wait for the command to execute. The default is 30 seconds."

@divega
Copy link

divega commented May 16, 2019

As recently announced in the .NET Blog, focus on new SqlClient features an improvements is moving to the new Microsoft.Data.SqlClient package. For this reason, we are moving this issue to the new repo at https://github.com/dotnet/SqlClient. We will still use https://github.com/dotnet/corefx to track issues on other providers like System.Data.Odbc and System.Data.OleDB, and general ADO.NET and .NET data access issues.

@divega divega transferred this issue from dotnet/corefx May 16, 2019
@David-Engel David-Engel added the 💡 Enhancement New feature request label May 20, 2019
@David-Engel David-Engel added this to the 1.1.0 milestone May 20, 2019
@cheenamalhotra cheenamalhotra moved this from To do to Review in progress in SqlClient v1.1.0 Oct 4, 2019
@cheenamalhotra
Copy link
Member

Hi @netdragonboberb

PR #243 shall update the tooltip and documentation as requested.
Just to let you know, starting with Microsoft.Data.SqlClient 1.1.0-preview1 we now support Intellisense for both .NET Framework and .NET Core for this driver.

@cheenamalhotra
Copy link
Member

Closing issue as PR #243 has been merged and fix shall be available in 1.1.0-preview2 release.

SqlClient v1.1.0 automation moved this from Review in progress to Done Oct 4, 2019
@David-Engel David-Engel modified the milestones: 1.1.0, 1.1.0-preview2 Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Enhancement New feature request
Projects
No open projects
Development

No branches or pull requests

4 participants