Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darc/maestro++] trigger-subscriptions should inform when matching subscriptions are disabled #2523

Open
2 tasks
Tracked by #2570
riarenas opened this issue Jun 3, 2020 · 0 comments
Open
2 tasks
Tracked by #2570

Comments

@riarenas
Copy link
Member

riarenas commented Jun 3, 2020

  • This issue is blocking
  • This issue is causing unreasonable pain

Had this situation come up in a customer question this week:

darc trigger-subscriptions --source-repo core-setup --target-repo diagnostictests --channel ".NET Core 3.1 Internal Servicing"
Will trigger the following 1 subscriptions...
  https://dev.azure.com/dnceng/internal/_git/dotnet-core-setup (.NET Core 3.1 Internal Servicing) ==> 'https://dev.azure.com/dnceng/internal/_git/dotnet-diagnostictests' ('release/3.1')
Continue? (y/n) y
Triggering 1 subscriptions...done

The subscription in question:

https://dev.azure.com/dnceng/internal/_git/dotnet-core-setup (.NET Core 3.1 Internal Servicing) ==> 'https://dev.azure.com/dnceng/internal/_git/dotnet-diagnostictests' ('release/3.1')
  - Id: dec3dc5c-371d-4fe1-4538-08d7d6786c95
  - Update Frequency: EveryDay
  - Enabled: False
  - Batchable: False
  - Merge Policies:
    NoRequestedChanges

Since the subscription is not enabled, a PR is not opened, and the user is left wondering why they are not seeing anything happen. We should inform the user that no enabled subscriptions match the criteria provided.

@riarenas riarenas changed the title [darc/maestro++] trigger-subscriptions should inform when a subscription is disabled, and that nothing will happen once it's triggered [darc/maestro++] trigger-subscriptions should inform when matching subscriptions are disabled Jun 3, 2020
@dkurepa dkurepa transferred this issue from dotnet/arcade Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants