Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard Version.Details.xml in non internal builds #2534

Open
Tracked by #2570
ViktorHofer opened this issue Feb 24, 2020 · 0 comments
Open
Tracked by #2570

Guard Version.Details.xml in non internal builds #2534

ViktorHofer opened this issue Feb 24, 2020 · 0 comments

Comments

@ViktorHofer
Copy link
Member

  • Is this issue blocking: no
  • Is this issue causing unreasonable pain: no

During a merge conflict in dotnet/runtime, the Version.Details.xml was incorrectly modified because of a missing tag. More details here: dotnet/runtime#32748.

Can we protect that path by adding the parsing step into the non-public builds?

cc @akoeplinger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants