Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update tracking changes documentation #2556

Open
eiriktsarpalis opened this issue Jul 24, 2019 · 8 comments
Open

Please update tracking changes documentation #2556

eiriktsarpalis opened this issue Jul 24, 2019 · 8 comments

Comments

@eiriktsarpalis
Copy link
Member

According to @ViktorHofer the instructions detailed in https://github.com/dotnet/core-setup/blob/master/Documentation/project-docs/how-to-track-changes.md are out of date. Could you possibly update them? cc @ericstj

@ericstj
Copy link
Member

ericstj commented Jul 24, 2019

/cc @noahfalk who wrote the doc and @dagood who's likely changed most of what I'm imagining @ViktorHofer's referring to.

@ViktorHofer
Copy link
Member

We aren't pushing to myget anymore therefore we need to update some parts of the doc. Happy to do that 😁

@ericstj
Copy link
Member

ericstj commented Jul 24, 2019

Probably lots of those package IDs and what not are wrong now with the 3.0 work as well.

@dagood
Copy link
Member

dagood commented Jul 24, 2019

It should be more straightforward now, broad strokes:

  1. To find the "root" commit hash, look at the package's nuspec, some .version file, in a binary, etc.
    • Losing MyGet and not having a browsable feed means I don't know how to do this without downloading a whole artifact.
  2. Open the repo at that commit.
  3. Look at eng/Version.Details.xml (all repos have this now).
  4. Use that to see what dependencies were involved in that build
  5. If necessary, use the repo URL listed there plus the commits mentioned to look recursively.

This process should be uniform from CoreCLR through Core-SDK since eng/Version.Details.xml is the backbone of dependency flow.

There is a darc command that should accelerate this by getting you the dependency graph from the BAR database, https://github.com/dotnet/arcade/blob/master/Documentation/Darc.md#viewing-the-dependency-graph. But I don't know how to use it, and BAR isn't available anonymously yet (#2566). There is a --local arg that might make it work without access to BAR.

/cc @mmitche

@ViktorHofer ViktorHofer removed their assignment Jul 26, 2019
@ViktorHofer
Copy link
Member

@dagood would you mind updating the doc with your details?

@dagood
Copy link
Member

dagood commented Jul 26, 2019

Can do, but I don't know when I'll have time. My comment lists all the stuff I know offhand, I'd have to look more into the scenarios in the doc to find suitable alternatives.

Something that would help get started is the entry point. How are you installing the SDK or runtimes that would be best to focus on as the artifact to start tracing from? (Not using NuGet packages as much anymore and not having a reasonably browsable package feed puts a damper on things.)

@dagood
Copy link
Member

dagood commented Jul 31, 2019

@markwilkie is it possible to address this from the Darc side, as part of tooling? Is there a doc about how to track down changes using Darc from artifacts?

Marking up for grabs because anyone could figure out what the process is and submit a PR to update the doc.

@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@NikolaMilosavljevic NikolaMilosavljevic transferred this issue from dotnet/runtime Dec 11, 2020
@NikolaMilosavljevic
Copy link
Member

[Triage notes] We believe that Arcade should provide a generic way for this, perhaps in Darc.

@dkurepa dkurepa transferred this issue from dotnet/arcade Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants