Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customization to signtool parallel repack limits #14242

Closed
2 tasks
mmitche opened this issue Nov 28, 2023 · 2 comments
Closed
2 tasks

Add customization to signtool parallel repack limits #14242

mmitche opened this issue Nov 28, 2023 · 2 comments
Assignees

Comments

@mmitche
Copy link
Member

mmitche commented Nov 28, 2023

  • This issue is blocking
  • This issue is causing unreasonable pain

Right now roslyn is sometimes hitting OOMs when repacking in parallel. I think this is because they have a ton of packages that are right around 65MB and we are probably trying to repack them all at the same time. The current limit is 2GB / 16 (128MB). Lowering the repack limit by half would still see most of those packages in below the limit. Lowering to 48MB for roslyn would probably work.

I think adding customization for this is probably the best way to go.

@mmitche
Copy link
Member Author

mmitche commented Nov 29, 2023

#14243

@mmitche mmitche self-assigned this Nov 29, 2023
@missymessa
Copy link
Member

PR for this work was merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants