Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maestro merges even if the PR reviewers have requested changes #1999

Closed
natemcmaster opened this issue Feb 7, 2019 · 7 comments
Closed

Maestro merges even if the PR reviewers have requested changes #1999

natemcmaster opened this issue Feb 7, 2019 · 7 comments
Assignees

Comments

@natemcmaster
Copy link
Contributor

From @natemcmaster on January 24, 2019 19:10

Is there a way to tell the bot to hold-off merging a PR? I figured the "request changes" gesture in GitHub reviews would have been honored, but apparently not: dotnet/efcore#14506

image

Copied from original issue: dotnet/arcade-services#103

@natemcmaster
Copy link
Contributor Author

@markwilkie do we triage issues in this repo? Or should I move this to dotnet/arcade?

@natemcmaster
Copy link
Contributor Author

From @mmitche on February 7, 2019 17:20

@natemcmaster I'd move it to arcade.

@natemcmaster
Copy link
Contributor Author

@markwilkie @mmitche can we give this issue consideration? Now that aspnet is enabling automerge, we'd still like a way to tell the bot to hold off merging.

@natemcmaster
Copy link
Contributor Author

cc @JunTaoLuo @dougbu

@mmitche
Copy link
Member

mmitche commented Apr 17, 2019

Ya, will see whether this is a quick fix.

@mmitche
Copy link
Member

mmitche commented Apr 30, 2019

@natemcmaster I think once the PR goes in (and a rollout happens) I'll go and bulk add this to all existing subscriptions.

@natemcmaster
Copy link
Contributor Author

Awesome 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants