-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maestro merges even if the PR reviewers have requested changes #1999
Comments
@markwilkie do we triage issues in this repo? Or should I move this to dotnet/arcade? |
From @mmitche on February 7, 2019 17:20 @natemcmaster I'd move it to arcade. |
@markwilkie @mmitche can we give this issue consideration? Now that aspnet is enabling automerge, we'd still like a way to tell the bot to hold off merging. |
Ya, will see whether this is a quick fix. |
@natemcmaster I think once the PR goes in (and a rollout happens) I'll go and bulk add this to all existing subscriptions. |
Awesome 👏 |
From @natemcmaster on January 24, 2019 19:10
Is there a way to tell the bot to hold-off merging a PR? I figured the "request changes" gesture in GitHub reviews would have been honored, but apparently not: dotnet/efcore#14506
Copied from original issue: dotnet/arcade-services#103
The text was updated successfully, but these errors were encountered: