Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darc/maestro++] Make merge policies source clear in darc output #2554

Open
mmitche opened this issue Aug 1, 2019 · 0 comments
Open

[darc/maestro++] Make merge policies source clear in darc output #2554

mmitche opened this issue Aug 1, 2019 · 0 comments
Assignees

Comments

@mmitche
Copy link
Member

mmitche commented Aug 1, 2019

@dougbu commented on Wed Jul 03 2019

darc get-subscriptions confusingly shows non-empty policies for batchable subscriptions. If this command is going to display repository policies, it should be clear the policies aren't actually part of the subscription definition. An alternative would be to show no policies or (perhaps best) to display just an indication that repo policies exist for the target branch.

For example,

darc get-subscriptions --target-repo https://github.com/aspnet/AspNetCore$ --regex --target-branch master --channel '.NET Tools - Latest'
https://github.com/dotnet/arcade (.NET Tools - Latest) ==> 'https://github.com/aspnet/AspNetCore' ('master')
  - Id: 4409590c-0c9e-4f51-7dbf-08d6ba16a224
  - Update Frequency: EveryWeek
  - Enabled: True
  - Batchable: True
  - Merge Policies:
    AllChecksSuccessful
      ignoreChecks =
                       [
                         "AspNetCore-helix-test",
                         "license/cla"
                       ]
    NoRequestedChanges
darc get-repository-policies --repo aspnet/AspNetCore --branch master
https://github.com/aspnet/AspNetCore @ master
- Merge Policies:
  AllChecksSuccessful
    ignoreChecks =
                   [
                     "AspNetCore-helix-test",
                     "license/cla"
                   ]
  NoRequestedChanges
https://github.com/aspnet/AspNetCore-Tooling @ master
- Merge Policies:
  Standard

@garath commented on Thu Jul 11 2019

@mmitche @jcagme Where's the best place to track this?


@mmitche commented on Thu Jul 11 2019

I this repo is fine. Need to create a p8 or GA epic for dependency flow to put this in.

@mmitche mmitche changed the title Make merge policies source clear in darc output [darc/maestro++] Make merge policies source clear in darc output Aug 1, 2019
@mmitche mmitche self-assigned this Aug 21, 2019
@dkurepa dkurepa transferred this issue from dotnet/arcade Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants