Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darc/maestro++] Feed cleaner service needs to handle symbol packages better #2533

Open
2 tasks
riarenas opened this issue Mar 12, 2020 · 3 comments
Open
2 tasks

Comments

@riarenas
Copy link
Member

  • This issue is blocking
  • This issue is causing unreasonable pain

The feed cleaner service's logs are filled with statements like:

Unable to find asset runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHostPolicy.3.1.3 in feed darc-pub-sym-dotnet-core-setup-644ff0fb in BAR. Unable to determine if it was released or update its locations.

Which means we're not cleaning up the stable symbol package feeds.

This is happening because we look for the BAR asset with a matching name to have the stable feed that we're attempting to clean up in the asset locations, but we never write the symbol feeds to the locations.

When looking up the asset, we can simply look for both the normal, and symbol feeds.

CC @mmitche @JohnTortugo @epananth

@mmitche
Copy link
Member

mmitche commented Mar 12, 2020

@riarenas I think the solution here might be simply to stop pushing the symbol packages to the azdo feeds? :D

@riarenas
Copy link
Member Author

That would make me even happier if we can do it! but we probably still need to tweak the cleaner, or maybe just wholesale delete all the stable symbol feeds after a bit?

@mmitche
Copy link
Member

mmitche commented Mar 12, 2020

Yep. The only requirements are that:

  1. We put the symbol packages somewhere
  2. The location is compatible with the need for internal builds
  3. The location is compatible with the need for stable builds (e.g. upload to a suffixed dir)

@dkurepa dkurepa transferred this issue from dotnet/arcade Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants