Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HostingRequestStartingLog shouldn't capture HttpRequest for its values #10556

Closed
benaadams opened this issue May 27, 2019 · 0 comments · Fixed by #10102
Closed

HostingRequestStartingLog shouldn't capture HttpRequest for its values #10556

benaadams opened this issue May 27, 2019 · 0 comments · Fixed by #10102
Labels
area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Milestone
Backlog

Comments

@benaadams
Copy link
Member

HostingRequestStartingLog captures HttpRequest for its values and resolves them from that.

If the logging happens lazily/out-of-line with the request (ConsoleLogger for example queues them) then the logging can happen outside of the request and the values be incorrect or reading them cause a race condition.
@benaadams benaadams mentioned this issue May 27, 2019
Merged
@halter73 halter73 mentioned this issue May 29, 2019
Closed
@analogrelay analogrelay modified the milestones: 3.0.0-preview7, Backlog Jun 14, 2019
@benaadams benaadams mentioned this issue Jun 30, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
Backlog
5 participants
@analogrelay @benaadams @JunTaoLuo @amcasey @mkArtakMSFT