Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the IHttpRequestBodyFeature interface exist? #13165

Closed
Taritsyn opened this issue Aug 15, 2019 · 5 comments
Closed

Does the IHttpRequestBodyFeature interface exist? #13165

Taritsyn opened this issue Aug 15, 2019 · 5 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions question

Comments

@Taritsyn
Copy link

After updating ASP.NET Core to version 3.0 Preview 8 in my project, that using the IHttpBufferingFeature interface, I received the following compilation error:

Error	CS0619	'IHttpBufferingFeature' is obsolete: 'See IHttpRequestBodyFeature or IHttpResponseBodyFeature DisableBuffering'

It is clear that I should refuse to use the obsolete interface, but it is completely unclear where the IHttpRequestBodyFeature interface is defined and whether it exists at all?

@mkArtakMSFT
Copy link
Member

Thanks for contacting us, @Taritsyn.
@Tratcher what's the alternative here?

@Tratcher
Copy link
Member

Not yet: #12620

Were you using DisableRequestBuffering? How/why?

Honestly we hadn't seen any reported usages of that API, it's not hooked up to anything by default.

@Taritsyn
Copy link
Author

Hello, Chris!

Were you using DisableRequestBuffering? How/why?

I use it for implementing ASP.NET Core middleware, which produce a markup minification and HTTP compression (see source code of the stream wrapper).

Honestly we hadn't seen any reported usages of that API, it's not hooked up to anything by default.

This API is mentioned here.

@Tratcher
Copy link
Member

That's only using response buffering. It only called request buffering as passthrough because they were combine on the old interface. You can remove that call.

@Taritsyn
Copy link
Author

ОК. Thank you!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2019
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions question
Projects
None yet
Development

No branches or pull requests

5 participants