-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion] ASP.NET Core SignalR MessagePack Hub Protocol moving to MessagePack v2.x package #18692
Comments
Special thanks to @tebeco for contributing this change! |
(and @AArnott / @BrennanConroy for their advice and patience) |
So for current LTS dotnet 3.1 we are bound to MessagePack 1.x family only, right? MessagePack 2.x is not compatible/supported until dotnet 5.x? |
yes for SignalR 3.x, you cannot update to so i would not say
I would rather say something like: |
@ChaosEngine Unfortunately yes, because of the breaking nature of the upgrade. The 3.1 LTS will continue to be on MessagePack 1.x. We have a good relationship with the authors of that package though, and expect to be able to continue patching critical issues in the MessagePack 1.x series of packages for the duration of the LTS. However, as is always the case when using non-Microsoft components like MessagePack, that isn't something we can guarantee (which is also why the MessagePack Hub protocol ships in a separate NuGet package rather than in the core Framework). |
Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog clean. If you believe there is a concern related to the ASP.NET Core framework, which hasn't been addressed yet, please file a new issue. This issue will be locked after 30 more days of inactivity. If you still wish to discuss this subject after then, please create a new issue! |
ASP.NET Core SignalR MessagePack Hub Protocol moving to MessagePack v2.x package
The ASP.NET Core SignalR MessagePack Hub Protocol uses the
MessagePack
NuGet package for MessagePack serialization. In ASP.NET Core 5.0, we will move from the 1.x version to the latest 2.x version. This is a breaking change for:MessagePackHubProtocolOptions
Version introduced
5.0-preview1
Old behavior
Previously, ASP.NET Core SignalR used the MessagePack 1.x package to serialize/deserialize MessagePack messages.
New behavior
Now, ASP.NET Core SignalR will use the MessagePack 2.x package to serialize/deserialize MessagePack messages.
Reason for change
We believe updating to MessagePack v2.x will add useful new functionality and allow us to stay current with the latest improvements in that package.
The new behavior will impact some aspects of message serialization and deserialization. See the guidance for migrating from 1.x to 2.x published by the MessagePack package authors. Specifically, there are behavioral changes to how DateTime values are serialized.
Recommended action
If you are using MessagePack directly in your application and using the SignalR MessagePack Hub Protocol, update your usage to adapt to any breaking changes in the 2.x release of MessagePack. The MessagePack package authors have published guidance for migrating from 1.x to 2.x.
Category
ASP.NET
Affected APIs
Microsoft.AspNetCore.SignalR.MessagePackHubProtocolOptions
This is the discussion issue for the following announcement: aspnet/Announcements#404
Issue metadata
The text was updated successfully, but these errors were encountered: