-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Caching.RedisStackExchange to refer to Redis.StackExchange 2.1 #28369
Comments
We were holding off on upgrades to this package on the advise of the maintainers but it looks like the referenced version (2.1.23) was released. Be aware that we don't update dependencies in patch releases, so this would only ship in 5.0 (targeting November 2020). You can upgrade the dependency yourself by just taking a direct dependency on StackExchange.Redis in your project at the later version. |
Thanks Andrew; we have certainly done the upgrade ourselves as you recommended. FWIW, while I understand that there's a point in not updating dependencies in patch releases, I wonder if there's reason for an exception every now and then. Because for example in this case, we never used Redis for anything else, so from our experience standpoint using the latest stable version of your recommended session storage library caused our application to have production problems because you've taken a dependency on a library that seems to have a issue particularly relevant to Azure. While the technical question of updating vs. not updating is non-trivial, the optics of this aren't too good either. |
Thanks for contacting us. |
Hello, I was hoping to get the upgrade done - but the version.details mentions using the Darc utility to upgrade existing . I tried following the markdown here- but it seems that the link is broken to join the arcade-contrib group which is required for one to get the BAR password generated. Please let me know if I am on the wrong trail here |
This would involve updating the entry under the "manual" section which does not make use of darc Line 162 in ed68ce7
|
If thats the change - it seems pretty trivial , I can PR it |
Done via #32239 |
Redis.StackExchange v2.0.593+ have an issue with connectivity to the Redis cluster randomly dying if there's a transient network error (until an AppDomain restart). See StackExchange/StackExchange.Redis#1374 and StackExchange/StackExchange.Redis#1120. These issues are fixed in 2.1.
It would probably make sense to release a version with an upgraded dependency, as this issue seems to be particularly bothering users with Azure Redis clusters.
The text was updated successfully, but these errors were encountered: