Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Caching.RedisStackExchange to refer to Redis.StackExchange 2.1 #28369

Closed
jouniheikniemi opened this issue May 3, 2020 · 7 comments
Closed
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware feature-caching Includes: StackExchangeRedis and SqlServer distributed caches
Milestone

Comments

@jouniheikniemi
Copy link

Redis.StackExchange v2.0.593+ have an issue with connectivity to the Redis cluster randomly dying if there's a transient network error (until an AppDomain restart). See StackExchange/StackExchange.Redis#1374 and StackExchange/StackExchange.Redis#1120. These issues are fixed in 2.1.

It would probably make sense to release a version with an upgraded dependency, as this issue seems to be particularly bothering users with Azure Redis clusters.

@analogrelay
Copy link
Contributor

We were holding off on upgrades to this package on the advise of the maintainers but it looks like the referenced version (2.1.23) was released.

Be aware that we don't update dependencies in patch releases, so this would only ship in 5.0 (targeting November 2020). You can upgrade the dependency yourself by just taking a direct dependency on StackExchange.Redis in your project at the later version.

@analogrelay analogrelay transferred this issue from dotnet/extensions May 7, 2020
@analogrelay analogrelay transferred this issue from dotnet/runtime May 7, 2020
@jouniheikniemi
Copy link
Author

Thanks Andrew; we have certainly done the upgrade ourselves as you recommended.

FWIW, while I understand that there's a point in not updating dependencies in patch releases, I wonder if there's reason for an exception every now and then. Because for example in this case, we never used Redis for anything else, so from our experience standpoint using the latest stable version of your recommended session storage library caused our application to have production problems because you've taken a dependency on a library that seems to have a issue particularly relevant to Azure. While the technical question of updating vs. not updating is non-trivial, the optics of this aren't too good either.

@JunTaoLuo JunTaoLuo transferred this issue from dotnet/extensions Dec 3, 2020
@JunTaoLuo JunTaoLuo added the feature-caching Includes: StackExchangeRedis and SqlServer distributed caches label Dec 3, 2020
@JunTaoLuo JunTaoLuo added this to the Next sprint planning milestone Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@shatadru-c
Copy link
Contributor

Hello, I was hoping to get the upgrade done - but the version.details mentions using the Darc utility to upgrade existing . I tried following the markdown here- but it seems that the link is broken to join the arcade-contrib group which is required for one to get the BAR password generated.

Please let me know if I am on the wrong trail here

@BrennanConroy
Copy link
Member

This would involve updating the entry under the "manual" section which does not make use of darc

<PropertyGroup Label="Manual">

@shatadru-c
Copy link
Contributor

shatadru-c commented Apr 27, 2021

If thats the change - it seems pretty trivial , I can PR it

@BrennanConroy
Copy link
Member

Done via #32239

@ghost ghost locked as resolved and limited conversation to collaborators May 31, 2021
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware feature-caching Includes: StackExchangeRedis and SqlServer distributed caches
Projects
None yet
Development

No branches or pull requests

6 participants