Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong nullable annotations on IHubProtocol.TryParseMessage in SignalR #28954

Closed
imb590 opened this issue Dec 31, 2020 · 1 comment · Fixed by #29219
Closed

Wrong nullable annotations on IHubProtocol.TryParseMessage in SignalR #28954

imb590 opened this issue Dec 31, 2020 · 1 comment · Fixed by #29219
Labels
area-signalr Includes: SignalR clients and servers
Milestone

Comments

@imb590
Copy link

imb590 commented Dec 31, 2020

The interface IHubProtocol should have HubMessage? type for its out parameter message. Existing implementations like JsonHubProtocol, MessagePackHubProtocol return null from this method.

@pranavkm pranavkm added the area-signalr Includes: SignalR clients and servers label Dec 31, 2020
@BrennanConroy BrennanConroy added this to the Next sprint planning milestone Dec 31, 2020
@ghost
Copy link

ghost commented Dec 31, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants