-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate productVersion.txt with repo-specific name #30004
Duplicate productVersion.txt with repo-specific name #30004
Conversation
In our efforts to unify the build access story using aka.ms links, we have found that there are certain files that share the same name in multiple different repositories, most importantly, productVersion.txt. As part of the work to move to aka.ms links, we will be flattening the short link paths, so rather than having a runtime-specific, aspnetcore-specific, etc. full path to the files generated by each of the repos, they will all go to the same short link location. This means that the path to productVersion.txt will collide in the aka.ms links (the backing locations are not changing and will be unaffected). To combat this, we will add a duplicate of each of the product repos productVersion.txt, renamed to indicate which product repo it came from, in this case aspnetcore-productVersion.txt. The original will remane so that we do not break existing scenarios that do not use the aka.ms links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming you've verified the outputs look good
Thanks Will. Verified with an official build run. aspnetcore-productVersion.txt is identical to productVersion.txt and both exist. |
@adiaaida do we need this in |
@dougbu Yes, we will. Thank you for the reminder. |
Duplicate productVersion.txt with repo-specific name
Duplicate productVersion.txt with repo-specific name
PR Title
Duplicate productVersion.txt with repo-specific name
PR Description
In our efforts to unify the build access story using aka.ms links, we have found that there are certain files that share the same name in multiple different repositories, most importantly, productVersion.txt. As part of the work to move to aka.ms links, we will be flattening the short link paths, so rather than having a runtime-specific, aspnetcore-specific, etc. full path to the files generated by each of the repos, they will all go to the same short link location. This means that the path to productVersion.txt will collide in the aka.ms links (the backing locations are not changing and will be unaffected). To combat this, we will add a duplicate of each of the product repos productVersion.txt, renamed to indicate which product repo it came from, in this case aspnetcore-productVersion.txt. The original will remane so that we do not break existing scenarios that do not use the aka.ms links.
Addresses dotnet/arcade#6862.