Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate productVersion.txt with repo-specific name #30004

Merged

Conversation

michellemcdaniel
Copy link
Contributor

@michellemcdaniel michellemcdaniel commented Feb 8, 2021

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
Duplicate productVersion.txt with repo-specific name

PR Description
In our efforts to unify the build access story using aka.ms links, we have found that there are certain files that share the same name in multiple different repositories, most importantly, productVersion.txt. As part of the work to move to aka.ms links, we will be flattening the short link paths, so rather than having a runtime-specific, aspnetcore-specific, etc. full path to the files generated by each of the repos, they will all go to the same short link location. This means that the path to productVersion.txt will collide in the aka.ms links (the backing locations are not changing and will be unaffected). To combat this, we will add a duplicate of each of the product repos productVersion.txt, renamed to indicate which product repo it came from, in this case aspnetcore-productVersion.txt. The original will remane so that we do not break existing scenarios that do not use the aka.ms links.

Addresses dotnet/arcade#6862.

In our efforts to unify the build access story using aka.ms links, we have found that there are certain files that share the same name in multiple different repositories, most importantly, productVersion.txt. As part of the work to move to aka.ms links, we will be flattening the short link paths, so rather than having a runtime-specific, aspnetcore-specific, etc. full path to the files generated by each of the repos, they will all go to the same short link location. This means that the path to productVersion.txt will collide in the aka.ms links (the backing locations are not changing and will be unaffected). To combat this, we will add a duplicate of each of the product repos productVersion.txt, renamed to indicate which product repo it came from, in this case aspnetcore-productVersion.txt. The original will remane so that we do not break existing scenarios that do not use the aka.ms links.
@michellemcdaniel michellemcdaniel requested a review from a team as a code owner February 8, 2021 21:16
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 8, 2021
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you've verified the outputs look good

@michellemcdaniel
Copy link
Contributor Author

Thanks Will. Verified with an official build run. aspnetcore-productVersion.txt is identical to productVersion.txt and both exist.

@dougbu
Copy link
Member

dougbu commented Feb 9, 2021

@adiaaida do we need this in release/5.0 as well❔

@michellemcdaniel
Copy link
Contributor Author

@dougbu Yes, we will. Thank you for the reminder.

@michellemcdaniel michellemcdaniel merged commit 511b5c1 into dotnet:main Feb 9, 2021
michellemcdaniel added a commit to michellemcdaniel/aspnetcore that referenced this pull request Feb 10, 2021
Duplicate productVersion.txt with repo-specific name
wtgodbe pushed a commit that referenced this pull request Feb 12, 2021
Duplicate productVersion.txt with repo-specific name
This was referenced Mar 10, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants