Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the new incremental source generator API in Razor source generator #31244

Closed
captainsafia opened this issue Mar 25, 2021 · 1 comment · Fixed by dotnet/sdk#18411
Closed

Switch to the new incremental source generator API in Razor source generator #31244

captainsafia opened this issue Mar 25, 2021 · 1 comment · Fixed by dotnet/sdk#18411
Assignees
@captainsafia
Labels
area-razor.compiler This issue is related to the Razor compiler (now external) Done This issue has been fixed feature-source-generators task
Projects
ASP.NET Core Blazor & MVC 6.0
Milestone
6.0-preview7

Comments

@captainsafia
Copy link
Member

Let's try out the new incremental source generator API introduced via dotnet/roslyn#51964 to bring in the benefits of more caching and the artifacts production API.
@captainsafia captainsafia added area-razor.compiler This issue is related to the Razor compiler (now external) feature-source-generators labels Mar 25, 2021
@captainsafia captainsafia added this to the 6.0-preview4 milestone Mar 25, 2021
@captainsafia captainsafia self-assigned this Mar 25, 2021
@mkArtakMSFT mkArtakMSFT added this to 6.0-Preview4 (16th April) in ASP.NET Core Blazor & MVC 6.0 Mar 25, 2021
@mkArtakMSFT mkArtakMSFT added task blocked The work on this issue is blocked due to some dependency labels Mar 25, 2021
@mkArtakMSFT mkArtakMSFT modified the milestones: 6.0-preview4, 6.0-preview5 Apr 1, 2021
@mkArtakMSFT mkArtakMSFT moved this from 6.0-Preview4 (16th April) to 6.0-preview5 in ASP.NET Core Blazor & MVC 6.0 Apr 1, 2021
@captainsafia captainsafia mentioned this issue Apr 7, 2021
Open
@captainsafia captainsafia mentioned this issue Apr 21, 2021
Closed
@mkArtakMSFT mkArtakMSFT changed the title Try out new incremental source generator API in Razor source generator Switch to the new incremental source generator API in Razor source generator May 3, 2021
@mkArtakMSFT mkArtakMSFT moved this from 6.0-preview5 (16th May) to 6.0-preview6 in ASP.NET Core Blazor & MVC 6.0 May 3, 2021
@mkArtakMSFT mkArtakMSFT modified the milestones: 6.0-preview5, 6.0-preview6 May 3, 2021
@mkArtakMSFT
Copy link
Member

Moving over to preview6, as the dependent work in the compiler has a high chance to get delayed.

@captainsafia captainsafia moved this from 6.0-preview6 (CC: 15th June) to In Progress in ASP.NET Core Blazor & MVC 6.0 May 24, 2021
@ghost ghost added the Working label May 24, 2021
@pranavkm pranavkm mentioned this issue May 25, 2021
Closed
@mkArtakMSFT mkArtakMSFT removed the blocked The work on this issue is blocked due to some dependency label Jun 17, 2021
@captainsafia captainsafia mentioned this issue Jun 21, 2021
Merged
ASP.NET Core Blazor & MVC 6.0 automation moved this from In Progress to Done Jun 24, 2021
@ghost ghost added Done This issue has been fixed and removed Working labels Jun 24, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@captainsafia captainsafia

Labels
area-razor.compiler This issue is related to the Razor compiler (now external) Done This issue has been fixed feature-source-generators task
Projects
No open projects
ASP.NET Core Blazor & MVC 6.0
Done
Milestone
6.0-preview7
Development

Successfully merging a pull request may close this issue.

Migrate Razor source generator incremental API dotnet/sdk
2 participants
@captainsafia @mkArtakMSFT