Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer collection interfaces like IList come from the body in minimal actions #32376

Closed
halter73 opened this issue May 4, 2021 · 4 comments
Closed
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-minimal-actions Controller-like actions for endpoint routing
Milestone

Comments

@halter73
Copy link
Member

halter73 commented May 4, 2021

Currently, all interface parameters without an attribute are inferred to be services. I like this simplicity, but it might be more convenient for developers if we inferred collection interface types like IList and IEnumerable are from the body instead. This complicates the mental model a bit and it's not that uncommon to consume multiple services using IEnumerable, but it's worth considering. See #31658 (comment)

@halter73 halter73 added enhancement This issue represents an ask for new feature or an enhancement to an existing one area-runtime feature-minimal-actions Controller-like actions for endpoint routing labels May 4, 2021
@BrennanConroy BrennanConroy added this to the Next sprint planning milestone May 5, 2021
@ghost
Copy link

ghost commented May 5, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@halter73
Copy link
Member Author

Given discussion in #32516, we might want to avoid doing this for collections of simple types. Or maybe we exclude arrays? That would feel a bit weird though.

@davidfowl
Copy link
Member

I think we should close this and wait for feedback.

@halter73
Copy link
Member Author

halter73 commented Jul 8, 2021

Agreed!

@halter73 halter73 closed this as completed Jul 8, 2021
@rafikiassumani-msft rafikiassumani-msft added this to 6-0-rc1 All in Minimal APIs 6.0 Jul 19, 2021
@rafikiassumani-msft rafikiassumani-msft removed this from 6-0-rc1 All in Minimal APIs 6.0 Jul 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2021
@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-minimal-actions Controller-like actions for endpoint routing
Projects
None yet
Development

No branches or pull requests

4 participants