Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Casing for route parameters in Minimal APIs #35087

Closed
rafikiassumani-msft opened this issue Aug 6, 2021 · 0 comments · Fixed by #35090
Closed

Ignore Casing for route parameters in Minimal APIs #35087

rafikiassumani-msft opened this issue Aug 6, 2021 · 0 comments · Fixed by #35090
Assignees
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-web-frameworks feature-minimal-actions Controller-like actions for endpoint routing
Milestone

Comments

@rafikiassumani-msft
Copy link
Contributor

Describe the bug

When the route parameters do not match due to casing, Minimal APIs throws an exception. We would like either to ignore casing and stay consistent with other other attributes.

To Reproduce

   app.MapGet("/user/{FirstName}/{lastName}", ([FromRoute()]string? firstName, [FromRoute()]string lastName) => 
    UserService.GetUser(firstName, lastName, "aa"));

Exceptions (if any)

Error message (Notice FirstName != firstName):

System.InvalidOperationException: 'firstName is not a route paramter.'

Further technical details

NET SDK (reflecting any global.json):
Version: 6.0.100-rc.1.21404.12
Commit: 78fb921136

Runtime Environment:
OS Name: Windows
OS Version: 10.0.19043
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\6.0.100-rc.1.21404.12\

Host (useful for support):
Version: 6.0.0-rc.1.21403.13
Commit: c082af307d

.NET SDKs installed:
3.1.411 [C:\Program Files\dotnet\sdk]
5.0.301 [C:\Program Files\dotnet\sdk]
5.0.302 [C:\Program Files\dotnet\sdk]
6.0.100-preview.6.21355.2 [C:\Program Files\dotnet\sdk]
6.0.100-rc.1.21404.12 [C:\Program Files\dotnet\sdk]

@rafikiassumani-msft rafikiassumani-msft added feature-minimal-actions Controller-like actions for endpoint routing area-web-frameworks labels Aug 6, 2021
@rafikiassumani-msft rafikiassumani-msft added this to the 6.0-rc1 milestone Aug 6, 2021
@rafikiassumani-msft rafikiassumani-msft added this to Ready in Minimal APIs 6.0 via automation Aug 6, 2021
Minimal APIs 6.0 automation moved this from Ready to Done Aug 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
@amcasey amcasey added the area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc label Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-web-frameworks feature-minimal-actions Controller-like actions for endpoint routing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants