Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Hot reload "Restart Application" VS gesture behaves badly #36914

Closed
SteveSandersonMS opened this issue Sep 24, 2021 · 2 comments
Closed

VS Hot reload "Restart Application" VS gesture behaves badly #36914

SteveSandersonMS opened this issue Sep 24, 2021 · 2 comments
Labels
area-blazor Includes: Blazor, Razor Components External This is an issue in a component not contained in this repository. It is open for tracking purposes. feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly feature-hot-reload This issue is related to the Hot Reload feaature

Comments

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Sep 24, 2021

There are some cases (with WebAssembly at least) where you have to restart the application to make your code changes really take effect, e.g., #36913. When you're in this situation you'll have to click "Restart Application", but the behavior is suboptimal:

  • Instead of refreshing your existing browser tab(s), it opens a whole new one.
    • It's not even on the URL you were on before, but instead resets back to the root URL.
    • Repeatedly opening tabs quickly clutters things up - you have to keep closing them manually.
  • The existing browser tab(s) are left in an infinite "reloading" state, so you have to manually refresh or close them

@pranavkm My guess is that the "open browser tab" behavior is controlled by VS and will need to be reported there, whereas the "existing tab never finishes reloading" behavior is likely controlled by our injected .js files. Is that correct?

reload-newtab

@SteveSandersonMS SteveSandersonMS added feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly feature-hot-reload This issue is related to the Hot Reload feaature labels Sep 24, 2021
@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Sep 24, 2021
@mkArtakMSFT
Copy link
Member

mkArtakMSFT commented Sep 30, 2021

@SteveSandersonMS the VS fix would eliminate that issue completely and there won't be a need to change a thing on our end. Would you mind reporting this through VS Feedback?

@mkArtakMSFT
Copy link
Member

@BillHiebert FYI

@mkArtakMSFT mkArtakMSFT added the External This is an issue in a component not contained in this repository. It is open for tracking purposes. label Sep 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components External This is an issue in a component not contained in this repository. It is open for tracking purposes. feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly feature-hot-reload This issue is related to the Hot Reload feaature
Projects
None yet
Development

No branches or pull requests

3 participants