Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http2ConnectionTests.ResponseTrailers_MultipleStreams_Reset test failure #37930

Closed
BrennanConroy opened this issue Oct 29, 2021 · 2 comments · Fixed by #38814
Closed

Http2ConnectionTests.ResponseTrailers_MultipleStreams_Reset test failure #37930

BrennanConroy opened this issue Oct 29, 2021 · 2 comments · Fixed by #38814
Assignees
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel test-failure test-fixed
Milestone

Comments

@BrennanConroy
Copy link
Member

I'm guessing #37627 regressed this test as it modified behavior in this area and was merged recently.

Failing Test(s)

Microsoft.AspNetCore.Server.Kestrel.Core.Tests.Http2ConnectionTests.ResponseTrailers_MultipleStreams_Reset

Error Message

Assert.Equal() Failure
Expected: 1
Actual:   0

Stacktrace

   at Microsoft.AspNetCore.Server.Kestrel.Core.Tests.Http2ConnectionTests.ResponseTrailers_MultipleStreams_Reset() in /_/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs:line 301
--- End of stack trace from previous location ---

Logs

[0.000s] [TestLifetime] [Information] Starting test ResponseTrailers_MultipleStreams_Reset at 2021-10-29T13:01:32
[0.017s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending SETTINGS frame for stream ID 0 with length 18 and flags NONE.
[0.017s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending WINDOW_UPDATE frame for stream ID 0 with length 4 and flags 0x0.
[0.017s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" received SETTINGS frame for stream ID 0 with length 0 and flags NONE.
[0.017s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending SETTINGS frame for stream ID 0 with length 0 and flags ACK.
[0.017s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" received HEADERS frame for stream ID 1 with length 97 and flags END_STREAM, END_HEADERS.
[0.020s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending HEADERS frame for stream ID 1 with length 36 and flags END_HEADERS.
[0.020s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending HEADERS frame for stream ID 1 with length 16 and flags END_STREAM, END_HEADERS.
[0.098s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" received PING frame for stream ID 0 with length 8 and flags NONE.
[0.099s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending PING frame for stream ID 0 with length 8 and flags ACK.
[0.099s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" received PING frame for stream ID 0 with length 8 and flags NONE.
[0.099s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending PING frame for stream ID 0 with length 8 and flags ACK.
[0.099s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" received HEADERS frame for stream ID 3 with length 5 and flags END_STREAM, END_HEADERS.
[0.100s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending HEADERS frame for stream ID 3 with length 6 and flags END_HEADERS.
[0.100s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending HEADERS frame for stream ID 3 with length 16 and flags END_STREAM, END_HEADERS.
[0.100s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" received PING frame for stream ID 0 with length 8 and flags NONE.
[0.100s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending PING frame for stream ID 0 with length 8 and flags ACK.
[0.101s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" received PING frame for stream ID 0 with length 8 and flags NONE.
[0.101s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending PING frame for stream ID 0 with length 8 and flags ACK.
[0.170s] [Microsoft.AspNetCore.Server.Kestrel.Core.Tests.Http2ConnectionTests] [Error] Test threw an exception.
Xunit.Sdk.EqualException: Assert.Equal() Failure
Expected: 1
Actual:   0
   at Xunit.Assert.Equal[T](T expected, T actual, IEqualityComparer`1 comparer) in C:\Dev\xunit\xunit\src\xunit.assert\Asserts\EqualityAsserts.cs:line 40
   at Microsoft.AspNetCore.Server.Kestrel.Core.Tests.Http2ConnectionTests.ResponseTrailers_MultipleStreams_Reset() in /_/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs:line 301
   at Xunit.Sdk.TestInvoker`1.<>c__DisplayClass48_1.<<InvokeTestMethodAsync>b__1>d.MoveNext() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestInvoker.cs:line 264
--- End of stack trace from previous location ---
   at Xunit.Sdk.ExecutionTimer.AggregateAsync(Func`1 asyncAction) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\ExecutionTimer.cs:line 48
   at Xunit.Sdk.ExceptionAggregator.RunAsync(Func`1 code) in C:\Dev\xunit\xunit\src\xunit.core\Sdk\ExceptionAggregator.cs:line 90
[0.171s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Debug] Connection id "TestConnectionId" is closed. The last processed stream ID was 3.
[0.171s] [Microsoft.AspNetCore.Server.Kestrel.Http2] [Verbose] Connection id "TestConnectionId" sending GOAWAY frame for stream ID 0 with length 8 and flags 0x0.
[0.180s] [TestLifetime] [Information] Finished test ResponseTrailers_MultipleStreams_Reset in 0.1796598s

Build

https://dev.azure.com/dnceng/public/_build/results?buildId=1446040&view=ms.vss-test-web.build-test-results-tab&runId=41665248&resultId=106843&paneView=debug

@HaoK
Copy link
Member

HaoK commented Dec 3, 2021

I think you forgot to mark this as test-fixed @halter73 30 days clean, so I'll unquarantine this and close

image

@halter73
Copy link
Member

halter73 commented Dec 3, 2021

You're right. Thanks @HaoK

@dotnet dotnet locked as resolved and limited conversation to collaborators Jan 3, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel test-failure test-fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants