Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignalR: Content-Type header in GET requests #41378

Closed
1 task done
jmajoor opened this issue Apr 26, 2022 · 5 comments · Fixed by #41517
Closed
1 task done

SignalR: Content-Type header in GET requests #41378

jmajoor opened this issue Apr 26, 2022 · 5 comments · Fixed by #41517
Labels
area-signalr Includes: SignalR clients and servers
Milestone

Comments

@jmajoor
Copy link

jmajoor commented Apr 26, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

WAF is flagging signalR long polling requests due to them having the Content-Type header on GET requests.

The issues was also report on the old code base: SignalR/SignalR#4373

Expected Behavior

There should be no content-type header for SignalR long polling GET requests.

Steps To Reproduce

Use a long polling TypeScript client to communicate to a signalR hub.
Inspect the long polling requests in the developer tools of the browser and you see that the GET requests have a content type set.
"Content-Type": "text/plain;charset=UTF-8",

Exceptions (if any)

No response

.NET Version

.NET 6

Anything else?

Ideally I would like to see POST requests and then also move the access token from the query string to the body of the request.

@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Apr 26, 2022
@rafikiassumani-msft rafikiassumani-msft added this to the .NET 7 Planning milestone Apr 26, 2022
@ghost
Copy link

ghost commented Apr 26, 2022

Thanks for contacting us.

We're moving this issue to the .NET 7 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@casmrv
Copy link

casmrv commented Apr 26, 2022

This has also been reported previously against asp.net.
Given that signalr long polling frequently ends up being the fallback due to network complexities, it would be good to get this fixed.

@BrennanConroy
Copy link
Member

We accept PRs 😃

This one should be fairly straightforward; my biggest concern is that react-native on android should be tested to make sure we don't break it again, as the addition of the header was made for that scenario.

@davidfowl
Copy link
Member

Ideally I would like to see POST requests and then also move the access token from the query string to the body of the request.

Not following this one. File a new issues and describe why, I'm not understanding the reasoning here.

@jmajoor
Copy link
Author

jmajoor commented Apr 27, 2022

@davidfowl, turns out that the issue I was hinting at (access tokens) has been properly addressed for long polling. This issue is just for the use of Content-Type in a GET operation. Sorry for the confusion.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants