[Codefixer] Recommend using TypedResults over using Results

[captainsafia]

Background and Motivation

• Recommend returning TypedResults instead of Results
• Recommend adding the Results<> return type to your class

app.MapGet("/", (int id) => SomeCondition(id) ? Results.Ok() : Results.NotFound());

Becomes

app.MapGet("/", (int id) => SomeCondition(id) ? TypedResults.Ok() : TypedResults.NotFound());

And further becomes:

app.MapGet("/", Results<Ok, NotFound>(int id) => SomeCondition(id) ? TypedResults.Ok() : TypedResults.NotFound());

Proposed Analyzer

Analyzer Behavior and Message

Category

• Design
• Documentation
• Globalization
• Interoperability
• Maintainability
• Naming
• Performance
• Reliability
• Security
• Style
• Usage

Severity Level

• Error
• Warning
• Info
• Hidden

Usage Scenarios

Risks

[captainsafia]

Cleaning things out and moving this to the backlog. I think this should be done in two parts: an analyzer to recommend TypedResults over Results and an analyzer to recommend adding the results type. IMO, the second one is probably less urgent.

Paging resident analyzer guru @david-acker for any interest/time in doing this.

[david-acker]

@captainsafia I'd be happy to pick this up when I have some free time!